Fc module various base tree admin updates #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: Correct `forkJunction` of canonical cursor head record. When moving the `base`, this field would be below `base` unless updated.
why: Given a sample ref `hash` the function searched for the unique chain containing the block header referenced by `hash`. Unfortunately, when searching down the ancestry lineage, the function did not necessarily stop an the end of the sub-chain. Rather it continued with the parent chain without noticing. So returning the wrong result.
why: The finalised block argument (that will eventually be the new base) might be moved further down the cursor arc if it is too close to the cursor head (typically smaller than 128 blocks.) So the finalised block selection is shifted down he cursor arc. And it might happen that the cursor arc itself is too small and one would end up at a parent cursor arc. This is rejected.
why: This leads to an inconsistent set of cursor arcs which are supposed to be mutually disjunct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.