Fc module can update base also when on parent arc #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why: Despite its name, `CanonicalDesc` contained a cursor arc (or leg) from the base tree with a designated block (or Header) on its arc members (aka blocks.) The type is used more generally than only for s block on the canonical cursor. Also, the `PivotArc` provides some more fields for caching intermediate data. This simplifies managing extra arguments for some functions.
details: No need to find cursor arc if it is given as function argument.
why: Better reading
details: Avoid the syllable `canonical` in function names that do not strictly apply to the canonical chain. So renaming * findCanonicalHead() => findCursorArc() * canonicalChain() => findHeader() * trimCanonicalChain() => trimCursorArc()
why: Will generalise action for more complex scenarios in future.
why: So it can directly be used as argument into `updateBase()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the magic happens in Update calculateNewBase() for target on parent arc. The other patches do not change any functionality.