-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate EL block hash when running consensus block tests #6406
Conversation
We currently don't have an easy way to test EL block hash computation. As the EL block hash in consensus-spec-tests is computed correctly, update the test runners that load block from test files to also verify the EL block hash. This increases missing test coverage. Requires ethereum/consensus-specs#3829
Cross-checked against jtraglia/consensus-specs#2 (with #6718) |
The hash is incorrect when there are empty txes, see status-im/nim-eth#744 (comment) As such blocks are invalid anyway as of ethereum/consensus-specs#3885, have excluded that condition from block hash consistency check. |
alpha.9 --> used to work but new tests got added after the latest fixes got merged. |
Still in alpha.10:
|
Yes, they keep adding breakages after the fixes :) |
Checked it against alpha.10 + the latest fix PR and nimbus passes with that. As long as no new incorrect block hashes get added by other PRs it should once more be alright (same as we hoped for during the earlier alphas which all worked against nimbus at a time). |
We currently don't have an easy way to test EL block hash computation. As the EL block hash in consensus-spec-tests is computed correctly, update the test runners that load block from test files to also verify the EL block hash. This increases missing test coverage.
Requires ethereum/consensus-specs#3829