-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Account History #1737
Redesign Account History #1737
Conversation
…icons of non standard sizes (#1673)
* makes swap amount persist across destination asset changes * updates swap test state to init with balances
* Allow creating a new wallet from initial screen * Added translations
* maintain password when switching between accounts * Added translations * add test and update e2e token
* enable e2e tests in CI and add cleanup tasks * fix asset code change
* Added translations * Add 'Disconnect all' button * Added translations * Display favicon
* Skip password when creating new address * Better copy for Enter Password screen * Added translations * Allow user to input password again in case of error + remove spinner while redirecting
…s simulate-tx API for other networks (#1694)
* adds use-get-history hook, and replaces data fetching for history using it * removes stray log * move loading render branch out of main render to avoid ternary * tweak hasEmptyHistory check to account for an empty operations list * renames use get history hook file to match repo conventions * renames var to follow code convention
* redesign the Create New Wallet screens and update tests * rm console.logs * fix checks in e2e login helpers * updating recovery snapshot. this screen will be redesigned in next PR * fix incorrect mnemonic phrase test
* Redesign Unfunded account notification * Add "Learn more" link on notification body
* redesign recover flow and add tests * Added translations * rm unnecessary pw check in cleanup and increase threshold of 24 word snapshot * fix threshold adjustment * make Toggle component tab-able * use box-shadow to align with Select * updating cleanup tasks in e2e tests
* redesign account view + account details QR code * apply same styling to network selector dropdown * fix checks for both dropdowns * Charles PR comments
* add github actions for deploying @stellar/freighter-api * use yarn to config tag and commit strings
* Redesign footer on UnlockAccount * Redesign input and button on UnlockAccount * Redesign text on UnlockAccount * Add identicon UI on UnlockAccount * Add service to set/load last used account * Workaround lint error * UI tweak * Extract reusable EnterPassword component * Use EnterPassword component on AddAccount screen * Use EnterPassword component on VerifyAccount screen * Added translations * Redesign NavBar for UnlockAccount screen * Make 1.5rem padding consistent in all screen contents (Figma) * Use pxToRem() * Hide Identicon on EnterPassword component in case address is not provided * Avoid using same name of the duck function * Update lastUsedAccount on Account screen instead of Sign out action * Change default description for EnterPassword * Added translations * Tweak text size and alignment * Set lastUsedAccount every time user subscribes to an account
Bumps the all-actions group with 7 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `2` | `4` | | [actions/setup-node](https://github.com/actions/setup-node) | `1` | `4` | | [jossef/action-set-json-field](https://github.com/jossef/action-set-json-field) | `1` | `2` | | [restackio/update-json-file-action](https://github.com/restackio/update-json-file-action) | `1e34d747ca044df80b37bc4ef5a9aa41be9dac8f` | `f8ef1561cb15ba86a6367b547216375bc60e7f91` | | [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) | `2.3.0` | `2.3.2` | | [frabert/replace-string-action](https://github.com/frabert/replace-string-action) | `1.2` | `2.5` | | [ruby/setup-ruby](https://github.com/ruby/setup-ruby) | `1.138.0` | `1.203.0` | Updates `actions/checkout` from 2 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) Updates `actions/setup-node` from 1 to 4 - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v1...v4) Updates `jossef/action-set-json-field` from 1 to 2 - [Release notes](https://github.com/jossef/action-set-json-field/releases) - [Commits](jossef/action-set-json-field@v1...2a0f7d9) Updates `restackio/update-json-file-action` from 1e34d747ca044df80b37bc4ef5a9aa41be9dac8f to f8ef1561cb15ba86a6367b547216375bc60e7f91 - [Release notes](https://github.com/restackio/update-json-file-action/releases) - [Commits](restackio/update-json-file-action@1e34d74...f8ef156) Updates `rtCamp/action-slack-notify` from 2.3.0 to 2.3.2 - [Release notes](https://github.com/rtcamp/action-slack-notify/releases) - [Commits](rtCamp/action-slack-notify@4e5fb42...c337377) Updates `frabert/replace-string-action` from 1.2 to 2.5 - [Release notes](https://github.com/frabert/replace-string-action/releases) - [Commits](frabert/replace-string-action@v1.2...b6828c5) Updates `ruby/setup-ruby` from 1.138.0 to 1.203.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@v1.138.0...v1.203.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions - dependency-name: jossef/action-set-json-field dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions - dependency-name: restackio/update-json-file-action dependency-type: direct:production dependency-group: all-actions - dependency-name: rtCamp/action-slack-notify dependency-type: direct:production update-type: version-update:semver-patch dependency-group: all-actions - dependency-name: frabert/replace-string-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: all-actions - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor dependency-group: all-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Overall this looks great. Just two questions / suggestions:
|
extension/src/popup/components/accountHistory/HistoryItem/index.tsx
Outdated
Show resolved
Hide resolved
extension/src/popup/components/accountHistory/HistoryItem/index.tsx
Outdated
Show resolved
Hide resolved
@JakeUrban do you mean removing the token code on the right here? That's actually an interesting idea so we'd have more room for the amount number
@JakeUrban I'm not against it. But curious to hear @sdfcharles thoughts on it. Thanks for reviewing! |
@piyalbasu thanks a lot for the help testing those. I haven't changed our existing Soroban logic on this PR since it looks a bit complex so I basically added the |
I think these rows have a potential to overflow their columns. Since we intend to show token transfers as sends, I think we should include some overflow/truncation of the columns. A custom token can define their |
hey @CassioMG - i'm good to make both of these changes that @JakeUrban suggested
|
@CassioMG everything lgtm, only one change:
|
@aristidesstaffieri that's a good point, thanks for raising it. |
Oh nice I thought the pill would overflow as well so that's not as bad. Yeah it's too bad we can't tweak the classname in order to make the pill truncate the text. I think this works, this should be a less common edge case. Thanks! |
Closing this in favor of #1785 since this one got too out of sync from master and rebasing this existing branch was too messy. I'll address the remainder PR comments on the new PR. |
Closes #1542
This PR redesigns the Account History screen on both the main History tab and the individual asset History.
Navigating on main History tab
Screen.Recording.2024-12-12.at.17.29.40.mov
Navigating on each asset History
Screen.Recording.2024-12-12.at.17.09.28.mov