Remove thiserror (extracted from #64) #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the thiserror crate and replace with the same code that would be generated. This change was authored by @overcat in #64, and has been extracted to commit separately. Co-authored-by: Jun Luo <[email protected]>
overcat
approved these changes
Sep 9, 2024
leighmcculloch
commented
Sep 9, 2024
overcat
reviewed
Sep 9, 2024
Merged
dmkozh
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove the thiserror crate and replace with the same code that would be generated.
Why
As @overcat pointed out in #64 (comment), the thiserror crate does very little, and crates a dependence on std that we plan to remove in #64.
This change was authored by @overcat in #64, and has been extracted to commit separately to reduce the dep graph created by this crate.
Known limitations
[TODO or N/A]