Try to get this package working again. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #8.
I do not understand the inner workings of this package at all, but I was able to fix the problems preventing it from building. The
config.hissue was pretty simple: the working directory Cabal was building from changed (we may need CPP to support older versions). A few other tweaks were needed. With these changes, it kind of works.I also looked at some forks, and found the changes at abarbu@5094eb0 by @abarbu, which I tried to integrate into the current version. I do not fully understand them, but they seem to help finding modules for the "load" operation.
Current status based on my limited testing:
The "eval" operation seg-faults if you run your code interpreted, or compiled with
-dynamic. I tried to figure this out but got nowhere. However, if compiled (statically), it seems to work.Running
loadfrom interpreted code takes about 1-2 seconds. Running it from compiled code takes about 8-9 seconds. I have found compiling with-dynamicrecovers the faster behavior. Again, I don't know how this stuff works, so have no explanation or solution.I haven't worked on any of the Stack, Travis, or deprecation issues, nor tested against versions of GHC other than 8.6.4.
So this is at least a first step. If we put our heads together, perhaps we can bring this package back from the dead.