fix issues reported by eslint and format md files

storybookjs · Nov 1, 2024 · 8d281d4 · 8d281d4
1 parent b737baa
commit 8d281d4
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -175,7 +175,7 @@ This plugin does not support MDX files.
 | [`storybook/no-uninstalled-addons`](./docs/rules/no-uninstalled-addons.md)                 | This rule identifies storybook addons that are invalid because they are either not installed or contain a typo in their name. |     | <ul><li>recommended</li><li>flat/recommended</li></ul>                                                            |
 | [`storybook/prefer-pascal-case`](./docs/rules/prefer-pascal-case.md)                       | Stories should use PascalCase                                                                                                 | 🔧  | <ul><li>recommended</li><li>flat/recommended</li></ul>                                                            |
 | [`storybook/story-exports`](./docs/rules/story-exports.md)                                 | A story file must contain at least one story export                                                                           |     | <ul><li>recommended</li><li>flat/recommended</li><li>csf</li><li>flat/csf</li></ul>                               |
-| [`storybook/use-storybook-expect`](./docs/rules/use-storybook-expect.md)                   | Use expect from `@storybook/jest`                                                                                             | 🔧  | <ul><li>addon-interactions</li><li>flat/addon-interactions</li><li>recommended</li><li>flat/recommended</li></ul> |
+| [`storybook/use-storybook-expect`](./docs/rules/use-storybook-expect.md)                   | Use expect from `@storybook/test` or `@storybook/jest`                                                                        | 🔧  | <ul><li>addon-interactions</li><li>flat/addon-interactions</li><li>recommended</li><li>flat/recommended</li></ul> |
 | [`storybook/use-storybook-testing-library`](./docs/rules/use-storybook-testing-library.md) | Do not use testing-library directly on stories                                                                                | 🔧  | <ul><li>addon-interactions</li><li>flat/addon-interactions</li><li>recommended</li><li>flat/recommended</li></ul> |
 
 <!-- RULES-LIST:END -->

diff --git a/lib/rules/no-uninstalled-addons.ts b/lib/rules/no-uninstalled-addons.ts
@@ -146,7 +146,8 @@ export = createStorybookRule({
         const parsedFile = JSON.parse(file)
         packageJson.dependencies = parsedFile.dependencies || {}
         packageJson.devDependencies = parsedFile.devDependencies || {}
-      } catch (e) {
+        // eslint-disable-next-line @typescript-eslint/no-unused-vars
+      } catch (err) {
         throw new Error(
           dedent`The provided path in your eslintrc.json - ${path} is not a valid path to a package.json file or your package.json file is not in the same folder as ESLint is running from.
 

diff --git a/lib/rules/prefer-pascal-case.ts b/lib/rules/prefer-pascal-case.ts
@@ -137,6 +137,7 @@ export = createStorybookRule({
               excludeStories: getDescriptor(meta, 'excludeStories'),
               includeStories: getDescriptor(meta, 'includeStories'),
             }
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
           } catch (err) {
             //
           }

diff --git a/lib/rules/story-exports.ts b/lib/rules/story-exports.ts
@@ -69,6 +69,7 @@ export = createStorybookRule({
               excludeStories: getDescriptor(meta, 'excludeStories'),
               includeStories: getDescriptor(meta, 'includeStories'),
             }
+            // eslint-disable-next-line @typescript-eslint/no-unused-vars
           } catch (err) {
             //
           }

diff --git a/lib/rules/use-storybook-expect.ts b/lib/rules/use-storybook-expect.ts
@@ -23,15 +23,13 @@ export = createStorybookRule<TDefaultOptions, string>({
   meta: {
     type: 'suggestion',
     fixable: 'code',
-    hasSuggestions: true,
     schema: [],
     docs: {
       description: 'Use expect from `@storybook/test` or `@storybook/jest`',
       categories: [CategoryId.ADDON_INTERACTIONS, CategoryId.RECOMMENDED],
       recommended: 'strict',
     },
     messages: {
-      updateImports: 'Update imports',
       useExpectFromStorybook:
         'Do not use global expect directly in the story. You should import it from `@storybook/test` or `@storybook/jest` instead.',
     },

diff --git a/tests/integrations/flat-config.spec.ts b/tests/integrations/flat-config.spec.ts
@@ -14,7 +14,9 @@ describe('Integration with flat config', () => {
     cp.execSync('pnpm i -f', { stdio: 'inherit' })
   })
   afterEach(() => {
-    originalCwd && process.chdir(originalCwd)
+    if (originalCwd) {
+      process.chdir(originalCwd)
+    }
   })
 
   it('should work with config', () => {

diff --git a/tests/integrations/legacy-config.spec.ts b/tests/integrations/legacy-config.spec.ts
@@ -14,7 +14,9 @@ describe('Integration with legacy config', () => {
     cp.execSync('pnpm i -f', { stdio: 'inherit' })
   })
   afterEach(() => {
-    originalCwd && process.chdir(originalCwd)
+    if (originalCwd) {
+      process.chdir(originalCwd)
+    }
   })
 
   it('should work with config', () => {