Do not suppress output via command-line option for mkfs.xfs or thin_check #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
thin-check-loud
branch
from
3c136bf to
ec9e3a4
Compare
mulkieran
changed the title
|
Cockpit tests failed for commit 3c136bf. @martinpitt, @jelly, @mvollmer please check. |
jbaublitz
approved these changes
Jan 8, 2024
drckeefe
approved these changes
Jan 8, 2024
bgurney-rh
approved these changes
Jan 8, 2024
stratisd does not need to suppress output via -q option to thin_check because the cmd module captures stderr and stdout streams and only reads them if the command returns an error. Signed-off-by: mulhern <[email protected]>
stratisd captures stdout and stderr and will only report the output on a failure of the command. No need to make xfs.mkfs quiet via a command-line option. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
thin-check-loud
branch
from
ec9e3a4 to
c0b10d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3520