Add new way of specifying post-test-checks #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
changed the title
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Feb 26, 2024
Signed-off-by: mulhern <[email protected]>
mulkieran
added a commit
to mulkieran/stratisd
that referenced
this pull request
Feb 26, 2024
Signed-off-by: mulhern <[email protected]>
The tearDown method does nothing, but still exists since the check classes extend unittest.TestCase. Signed-off-by: mulhern <[email protected]>
As the number of post-test checks that we can usefully do proliferate, specifying each one via a separate option is going to become more and more inconvenient. Leave the old way in place. It can be dropped after the next release. Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
post-test-checks
branch
from
879c419 to
c651579
Compare
mulkieran
requested review from
bgurney-rh
and removed request for
bgurney-rh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #239