Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stratisd_cert.py: setUp -> tearDown #261

Merged
merged 1 commit into from
May 21, 2024
Merged

stratisd_cert.py: setUp -> tearDown #261

merged 1 commit into from
May 21, 2024

Conversation

mulkieran
Copy link
Member

@mulkieran mulkieran commented May 21, 2024 •
edited
Loading

Related #259

@mulkieran
stratisd_cert.py: setUp -> tearDown
3ec17ec 
A notable effect of calling setUp instead of tearDown in the tearDown
method is that the dbus monitor script is cleaned up early.

That tearDown is not called is barely noticeable, since there is a
clean_up method that is invoked after the tests concludes, regardless of
whether it succeeded or failed.

Signed-off-by: mulhern <[email protected]>
@mulkieran mulkieran self-assigned this May 21, 2024
@mulkieran
Copy link
Member Author

tested

@mulkieran mulkieran merged commit 8c45a0e into stratis-storage:master May 21, 2024
4 checks passed
@mulkieran mulkieran deleted the fix-typo branch May 21, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mulkieran mulkieran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mulkieran