Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not do D-bus monitoring for one failing test #301

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Do not do D-bus monitoring for one failing test #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stratis_cli_cert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ def setUp(self):
"""
super().setUp()

self._post_test_checks = RunPostTestChecks()
self._post_test_checks = RunPostTestChecks(test_id=self.id())

def tearDown(self):
"""
Expand Down
2 changes: 1 addition & 1 deletion stratisd_cert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def setUp(self):
"""
super().setUp()

self._post_test_checks = RunPostTestChecks()
self._post_test_checks = RunPostTestChecks(test_id=self.id())

def tearDown(self):
"""
Expand Down
6 changes: 4 additions & 2 deletions testlib/infra.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,12 +621,14 @@ class RunPostTestChecks:
Manage running post test checks
"""

def __init__(self):
def __init__(self, *, test_id=None):
"""
Set up checks that need to be started before test is run.
"""
self.dbus_monitor = DbusMonitor()
self.dbus_monitor.setUp()
# See: https://github.com/stratis-storage/project/issues/741
if test_id is None or not test_id.endswith("test_pool_add_data_init_cache"):
self.dbus_monitor.setUp()

def teardown(self):
"""
Expand Down
Loading