Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix jdc sigterm signalling issue #1321

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix jdc sigterm signalling issue #1321

wants to merge 1 commit into from

Conversation

Shourya742
Copy link
Contributor

@Shourya742 Shourya742 commented Dec 23, 2024 •
edited
Loading

closes: #1266

Description

This PR introduces several key changes to the JobDeclaratorClient implementation to enhance its functionality, improve shutdown handling, and resolve blocking issues during task execution:

  1. Use of tokio::spawn for Task Initialization

    • The initialize_jd and initialize_jd_as_solo_miner methods are now executed using tokio::spawn.
    • Previously, these methods were directly awaited in the event loop, causing blocking issues on disconnection events. By spawning these tasks, we ensure the event loop remains responsive.

  2. Refactored Method Signatures

    • Adjusted the signatures of initialize_jd and initialize_jd_as_solo_miner to accept ProxyConfig as a parameter instead of relying on &self.
    • This change prevents self from being moved into the spawned tasks and allows for proper cloning and reuse within the async context.

  3. Graceful Shutdown Mechanism

    • Introduced a tokio::sync::Notify instance as part of JobDeclaratorClient struct to handle shutdown signals. Which now gives power to struct initializer to shutdown process directly.
    • Replaced the previous ctrl_c signal handling with a task that listens for the signal and triggers the shutdown notifier.

  4. Simplified Interrupt Signal Handling

    • Removed the manual handling of ctrl_c interrupt futures within the select loop.
    • Graceful shutdown now exits the process when the notifier is triggered.

@Shourya742 Shourya742 mentioned this pull request Dec 23, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,654.20
(+1.41%)		6,989.24
(95.21%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,327.90
(-1.05%)		7,858.78
(93.24%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,999.50
(-1.15%)		9,501.44
(84.19%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		876.09
(+0.68%)		949.96
(92.22%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		677.62
(-0.10%)		726.88
(93.22%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		263.24
(+4.48%)		283.17
(92.96%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		165.22
(+4.26%)		171.81
(96.16%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,225.70
(-1.65%)		6,755.01
(92.16%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		280.29
(-2.77%)		378.65
(74.02%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		713.23
(-1.98%)		781.50
(91.26%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		596.70
(+0.64%)		641.28
(93.05%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		205.52
(-0.63%)		228.46
(89.96%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.13
(+0.64%)		2.24
(95.09%)		📈 view plot
🚷 view threshold		473.00
(-0.14%)		490.49
(96.43%)		📈 view plot
🚷 view threshold		734.00
(-0.27%)		758.91
(96.72%)		📈 view plot
🚷 view threshold		6.00
(+16.72%)		11.61
(51.69%)		📈 view plot
🚷 view threshold		39.00
(+0.83%)		41.76
(93.39%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.32
(+1.14%)		8.40
(99.04%)		📈 view plot
🚷 view threshold		2,137.00📈 view plot
🚷 view threshold		3,152.00
(-0.21%)		3,167.46
(99.51%)		📈 view plot
🚷 view threshold		40.00
(+12.23%)		41.66
(96.02%)		📈 view plot
🚷 view threshold		142.00
(+1.62%)		144.63
(98.18%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.35
(+0.79%)		6.45
(98.49%)		📈 view plot
🚷 view threshold		1,750.00
(-0.04%)		1,767.49
(99.01%)		📈 view plot
🚷 view threshold		2,548.00
(-0.15%)		2,575.34
(98.94%)		📈 view plot
🚷 view threshold		19.00
(+10.65%)		24.04
(79.04%)		📈 view plot
🚷 view threshold		106.00
(+1.22%)		108.82
(97.41%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.80
(+0.52%)		14.94
(99.10%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.49
(99.63%)		📈 view plot
🚷 view threshold		6,749.00
(-0.10%)		6,786.69
(99.44%)		📈 view plot
🚷 view threshold		50.00
(+8.92%)		63.36
(78.92%)		📈 view plot
🚷 view threshold		223.00
(+0.82%)		226.16
(98.60%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.79
(+0.65%)		28.07
(99.00%)		📈 view plot
🚷 view threshold		10,645.00
(+0.35%)		10,700.14
(99.48%)		📈 view plot
🚷 view threshold		15,503.00
(+0.39%)		15,596.66
(99.40%)		📈 view plot
🚷 view threshold		91.00
(+8.43%)		99.35
(91.59%)		📈 view plot
🚷 view threshold		338.00
(+0.72%)		343.27
(98.47%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.45
(+0.96%)		4.59
(96.95%)		📈 view plot
🚷 view threshold		1,461.00
(-0.05%)		1,478.49
(98.82%)		📈 view plot
🚷 view threshold		2,157.00
(-0.17%)		2,184.65
(98.73%)		📈 view plot
🚷 view threshold		10.00
(+21.44%)		14.00
(71.44%)		📈 view plot
🚷 view threshold		64.00
(+1.68%)		67.89
(94.27%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14.02
(+0.03%)		14.20
(98.74%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,081.49
(99.66%)		📈 view plot
🚷 view threshold		7,324.00
(-0.03%)		7,352.71
(99.61%)		📈 view plot
🚷 view threshold		38.00
(+3.40%)		48.32
(78.64%)		📈 view plot
🚷 view threshold		186.00
(-0.00%)		190.86
(97.45%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.82
(+0.49%)		23.08
(98.91%)		📈 view plot
🚷 view threshold		8,040.00
(+0.09%)		8,057.61
(99.78%)		📈 view plot
🚷 view threshold		11,689.00
(+0.03%)		11,713.53
(99.79%)		📈 view plot
🚷 view threshold		85.00
(+11.92%)		90.08
(94.36%)		📈 view plot
🚷 view threshold		306.00
(+0.59%)		312.90
(97.79%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.71
(+0.39%)		4.79
(98.28%)		📈 view plot
🚷 view threshold		1,502.00
(-0.04%)		1,519.49
(98.85%)		📈 view plot
🚷 view threshold		2,276.00
(-0.12%)		2,300.85
(98.92%)		📈 view plot
🚷 view threshold		11.00
(+16.36%)		15.26
(72.07%)		📈 view plot
🚷 view threshold		68.00
(+0.57%)		70.18
(96.90%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.21
(+0.32%)		16.33
(99.26%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,980.49
(99.71%)		📈 view plot
🚷 view threshold		8,655.00
(-0.10%)		8,692.65
(99.57%)		📈 view plot
🚷 view threshold		48.00
(+17.54%)		56.45
(85.03%)		📈 view plot
🚷 view threshold		209.00
(+0.35%)		212.20
(98.49%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.75
(+0.41%)		35.96
(99.42%)		📈 view plot
🚷 view threshold		14,888.00
(+0.13%)		14,920.01
(99.79%)		📈 view plot
🚷 view threshold		21,867.00
(+0.10%)		21,919.53
(99.76%)		📈 view plot
🚷 view threshold		110.00
(+16.00%)		120.36
(91.40%)		📈 view plot
🚷 view threshold		381.00
(+0.35%)		385.77
(98.76%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.39
(-0.70%)		8.67
(96.80%)		📈 view plot
🚷 view threshold		3.69
(-0.92%)		3.86
(95.54%)		📈 view plot
🚷 view threshold		5.16
(-1.08%)		5.45
(94.65%)		📈 view plot
🚷 view threshold		11.00
(+28.70%)		16.47
(66.77%)		📈 view plot
🚷 view threshold		91.00
(-0.48%)		96.80
(94.01%)
get_submit📈 view plot
🚷 view threshold		95.22
(-0.15%)		95.61
(99.58%)		📈 view plot
🚷 view threshold		59.35
(-0.09%)		59.71
(99.39%)		📈 view plot
🚷 view threshold		85.22
(-0.09%)		85.82
(99.31%)		📈 view plot
🚷 view threshold		45.00
(+0.23%)		60.44
(74.46%)		📈 view plot
🚷 view threshold		279.00
(-0.63%)		291.87
(95.59%)
get_subscribe📈 view plot
🚷 view threshold		7.91
(-1.03%)		8.23
(96.12%)		📈 view plot
🚷 view threshold		2.77
(-1.63%)		2.94
(93.98%)		📈 view plot
🚷 view threshold		3.85
(-1.92%)		4.14
(92.83%)		📈 view plot
🚷 view threshold		15.00
(+18.89%)		20.91
(71.73%)		📈 view plot
🚷 view threshold		114.00
(-0.46%)		117.92
(96.67%)
serialize_authorize📈 view plot
🚷 view threshold		12.12
(-1.14%)		12.51
(96.88%)		📈 view plot
🚷 view threshold		5.27
(-0.58%)		5.43
(97.05%)		📈 view plot
🚷 view threshold		7.33
(-0.68%)		7.60
(96.37%)		📈 view plot
🚷 view threshold		13.00
(+25.97%)		18.98
(68.49%)		📈 view plot
🚷 view threshold		135.00
(-2.14%)		143.36
(94.17%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.71
(-0.02%)		25.19
(98.10%)		📈 view plot
🚷 view threshold		9.84
(-0.18%)		10.01
(98.28%)		📈 view plot
🚷 view threshold		13.87
(-0.24%)		14.17
(97.87%)		📈 view plot
🚷 view threshold		39.00
(+8.36%)		46.02
(84.74%)		📈 view plot
🚷 view threshold		304.00
(+0.12%)		313.67
(96.92%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.22
(-0.34%)		30.73
(98.34%)		📈 view plot
🚷 view threshold		12.02
(-0.28%)		12.19
(98.60%)		📈 view plot
🚷 view threshold		17.00
(-0.35%)		17.30
(98.27%)		📈 view plot
🚷 view threshold		61.00
(+9.14%)		67.57
(90.28%)		📈 view plot
🚷 view threshold		369.00
(-0.54%)		379.48
(97.24%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.29
(-0.13%)		126.79
(99.61%)		📈 view plot
🚷 view threshold		73.20
(-0.06%)		73.53
(99.55%)		📈 view plot
🚷 view threshold		104.91
(-0.08%)		105.51
(99.44%)		📈 view plot
🚷 view threshold		110.00
(+2.95%)		125.87
(87.39%)		📈 view plot
🚷 view threshold		595.00
(-0.46%)		610.67
(97.43%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.82
(-0.31%)		28.38
(98.01%)		📈 view plot
🚷 view threshold		9.58
(-0.47%)		9.76
(98.21%)		📈 view plot
🚷 view threshold		13.53
(-0.60%)		13.84
(97.78%)		📈 view plot
🚷 view threshold		72.00
(+11.34%)		78.26
(92.01%)		📈 view plot
🚷 view threshold		398.00
(-0.31%)		409.79
(97.12%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.16
(-0.07%)		115.71
(99.52%)		📈 view plot
🚷 view threshold		68.06
(+0.01%)		68.42
(99.47%)		📈 view plot
🚷 view threshold		97.65
(+0.01%)		98.29
(99.35%)		📈 view plot
🚷 view threshold		65.00
(-1.11%)		87.79
(74.04%)		📈 view plot
🚷 view threshold		491.00
(-0.50%)		505.35
(97.16%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.24
(-0.35%)		23.82
(97.58%)		📈 view plot
🚷 view threshold		8.14
(-0.50%)		8.32
(97.93%)		📈 view plot
🚷 view threshold		11.45
(-0.60%)		11.75
(97.48%)		📈 view plot
🚷 view threshold		41.00
(+4.83%)		51.27
(79.97%)		📈 view plot
🚷 view threshold		331.00
(-0.20%)		342.45
(96.66%)
serialize_submit📈 view plot
🚷 view threshold		99.60
(-0.19%)		100.09
(99.51%)		📈 view plot
🚷 view threshold		61.41
(-0.07%)		61.73
(99.47%)		📈 view plot
🚷 view threshold		88.08
(-0.08%)		88.65
(99.37%)		📈 view plot
🚷 view threshold		49.00
(+1.46%)		67.13
(72.99%)		📈 view plot
🚷 view threshold		322.00
(-1.05%)		337.63
(95.37%)
serialize_subscribe📈 view plot
🚷 view threshold		11.35
(-0.41%)		11.60
(97.88%)		📈 view plot
🚷 view threshold		4.12
(-1.01%)		4.28
(96.16%)		📈 view plot
🚷 view threshold		5.71
(-1.25%)		6.00
(95.16%)		📈 view plot
🚷 view threshold		16.00
(+13.90%)		24.42
(65.51%)		📈 view plot
🚷 view threshold		159.00
(+0.28%)		164.64
(96.57%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024 •
edited
Loading

🐰 Bencher Report

Branch2024-12-23-fix-sigterm-jdc
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		44.46
(-1.98%)		60.95
(72.94%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		73.14
(-4.62%)		104.74
(69.83%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.66
(-0.06%)		14.73
(99.53%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		262.83
(-0.16%)		285.52
(92.05%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		598.94
(-3.13%)		684.04
(87.56%)
client_sv2_open_channel📈 view plot
🚷 view threshold		162.06
(-2.22%)		179.28
(90.39%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		294.16
(+2.46%)		317.78
(92.57%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		377.33
(-1.25%)		399.41
(94.47%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		163.77
(+2.31%)		171.68
(95.39%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		474.19
(+1.04%)		552.24
(85.87%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,059.20
(+4.69%)		1,245.95
(85.01%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.11%. Comparing base (7483090) to head (b1e6780).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
roles/jd-client/src/lib/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   19.14%   19.11%   -0.04%     
==========================================
  Files         166      166              
  Lines       10987    11047      +60     
==========================================
+ Hits         2104     2112       +8     
- Misses       8883     8935      +52
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.56% <ø> (-0.09%) ⬇️
binary_sv2-coverage 5.36% <ø> (-0.13%) ⬇️
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage ?
codec_sv2-coverage 0.01% <ø> (-0.01%) ⬇️
common_messages_sv2-coverage 0.13% <ø> (-0.01%) ⬇️
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.28% <ø> (-0.01%) ⬇️
jd_client-coverage 0.00% <0.00%> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.43% <ø> (?)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.46% <ø> (?)
pool_sv2-coverage 2.05% <ø> (ø)
protocols 24.63% <ø> (-0.11%) ⬇️
roles 6.55% <0.00%> (ø)
roles_logic_sv2-coverage 7.95% <ø> (-0.17%) ⬇️
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.42% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 3aa0262 to 6bb7eb0 Compare December 23, 2024 16:47
jbesraa
jbesraa suggested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain in the commit what is the ACTUAL fix. What are you doing in order to fix the issue.

@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 6bb7eb0 to 65512c1 Compare January 3, 2025 05:01
@plebhash plebhash mentioned this pull request Jan 3, 2025
Open
@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 65512c1 to a3efa46 Compare January 5, 2025 03:51
@plebhash
Copy link
Collaborator

plebhash commented Jan 6, 2025

tACK

I found a typo, but overall LGTM

@plebhash plebhash added this to the 1.3.0 milestone Jan 6, 2025
@plebhash plebhash added the roles Pertains to all roles label Jan 6, 2025
jbesraa
jbesraa suggested changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. Added a few nits.

Regarding this commit 6a95deb could you please explain why it is added? the title says "move task_status block inside the select macro" but it is not clear why the task_status was moved. maybe add that in the commit body.

a0ffe75 could have a better title, maybe "Fix typo", or you could just fix it up to the second commit(a3efa46).

roles/jd-client/src/lib/mod.rs Outdated Show resolved Hide resolved
roles/jd-client/src/lib/mod.rs Outdated Show resolved Hide resolved
roles/jd-client/src/lib/mod.rs Outdated Show resolved Hide resolved
@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from a0ffe75 to 0352e78 Compare January 9, 2025 15:56
@Shourya742
Copy link
Contributor Author

@jbesraa I have incorporated your suggestions and updated the commit history to a single commit since the changes are closely related.

@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 0352e78 to a9fb6f4 Compare January 9, 2025 16:04
jbesraa
jbesraa suggested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested this locally and it seems that the ghost processes are gone! so this is good to go

roles/jd-client/src/lib/mod.rs Outdated Show resolved Hide resolved
@Shourya742
-Fix jdc sigterm signalling issue
b1e6780 
It changes the structuring of the start method, to avoid its blocking nature in case of
disconnection from the upstream. Currently, when we are sending the termination signal, during the
stance of disconnection from upstream, due of blocking nature of initialize_jd it halts the main
thread runtime from executing select block, which listens for any termination signal and channel
responses.

-Modifications
1. Addition of new shutdown field, which can be used later in integration test to terminate the instances
2. Change argument type for methods initialize_jd and initialize_jd_solo, to make them movable.
3. Spawning of blocking process as a separate task
@Shourya742 Shourya742 force-pushed the 2024-12-23-fix-sigterm-jdc branch from 0e02c9f to b1e6780 Compare January 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash approved these changes

@jbesraa jbesraa jbesraa approved these changes

Assignees
No one assigned
Labels
roles Pertains to all roles
Projects
SV2 Roadmap 🛣️
Status: Ready For Review 🔍
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Investigate ghost processes in tproxy and JDC
3 participants
@Shourya742 @plebhash @jbesraa