Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-libs.yaml use 1.75.0 toolchain #1331

Merged
merged 1 commit into from
Jan 7, 2025
Merged

release-libs.yaml use 1.75.0 toolchain #1331

merged 1 commit into from
Jan 7, 2025

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Jan 7, 2025 •
edited
Loading

follow up to #1329

it turns out that cargo v1.83.0 (which is the current stable toolchain) outputs the following string when cargo publish is trying to publish a crate that has already been published:

$ cargo +stable publish
    Updating crates.io index
error: crate [email protected] already exists on crates.io index

but the script checks for a different string, which is the output of cargo v1.75.0 (MSRV):

$ cargo +1.75.0 publish
error: failed to publish to registry at https://crates.io

Caused by:
  the remote server responded with an error (status 400 Bad Request): crate version `1.0.0` is already uploaded

one could argue:

why not adapt scripts/release-libs.sh to look for the already exists on crates.io index string?

that would be suboptimal, because in the future a new stable could use yet another different string, which would break the workflow again (making us forever chase a moving target)

so it's better to simply always run the workflow under MSRV and always have a predictable outcome

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🐰 Bencher Report

Branchfix-release-libs-toolchain
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,508.50
(-0.97%)		6,939.23
(93.79%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,369.80
(-0.71%)		7,862.99
(93.73%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		7,996.40
(-1.43%)		9,414.69
(84.94%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		862.12
(-0.87%)		945.85
(91.15%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		664.37
(-1.54%)		718.13
(92.51%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		246.30
(-1.17%)		265.95
(92.61%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		156.45
(-0.77%)		167.13
(93.61%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,242.30
(-1.78%)		6,810.32
(91.66%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		289.83
(+2.00%)		328.14
(88.33%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		725.96
(-0.30%)		779.81
(93.09%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		588.47
(-0.57%)		625.90
(94.02%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		210.17
(+1.35%)		227.33
(92.45%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🐰 Bencher Report

Branchfix-release-libs-toolchain
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.60
(+0.81%)		60.05
(75.95%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		74.65
(-3.77%)		107.33
(69.55%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.65
(-0.05%)		14.72
(99.56%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		264.15
(-0.67%)		291.25
(90.70%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		637.45
(+3.59%)		659.06
(96.72%)
client_sv2_open_channel📈 view plot
🚷 view threshold		166.86
(+0.51%)		179.08
(93.18%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		279.87
(-1.80%)		311.40
(89.87%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		378.67
(-0.81%)		400.17
(94.63%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		159.55
(-0.37%)		172.12
(92.70%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		494.54
(+4.68%)		557.46
(88.71%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		1,011.40
(+0.65%)		1,172.53
(86.26%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🐰 Bencher Report

Branchfix-release-libs-toolchain
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2.13
(+1.00%)		2.23
(95.51%)		📈 view plot
🚷 view threshold		473.00
(-0.09%)		490.93
(96.35%)		📈 view plot
🚷 view threshold		733.00
(-0.39%)		759.80
(96.47%)		📈 view plot
🚷 view threshold		7.00
(+38.91%)		11.93
(58.66%)		📈 view plot
🚷 view threshold		39.00
(+1.05%)		41.63
(93.67%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8.31
(+1.05%)		8.39
(99.00%)		📈 view plot
🚷 view threshold		2,137.00
(-0.00%)		2,138.71
(99.92%)		📈 view plot
🚷 view threshold		3,155.00
(-0.12%)		3,168.07
(99.59%)		📈 view plot
🚷 view threshold		37.00
(+3.97%)		41.82
(88.48%)		📈 view plot
🚷 view threshold		142.00
(+1.70%)		144.37
(98.36%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6.36
(+0.97%)		6.45
(98.67%)		📈 view plot
🚷 view threshold		1,750.00
(-0.03%)		1,767.83
(98.99%)		📈 view plot
🚷 view threshold		2,546.00
(-0.22%)		2,576.12
(98.83%)		📈 view plot
🚷 view threshold		21.00
(+22.07%)		24.63
(85.27%)		📈 view plot
🚷 view threshold		106.00
(+1.30%)		108.72
(97.50%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14.82
(+0.63%)		14.93
(99.21%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.83
(99.62%)		📈 view plot
🚷 view threshold		6,746.00
(-0.15%)		6,786.78
(99.40%)		📈 view plot
🚷 view threshold		53.00
(+16.97%)		62.18
(85.24%)		📈 view plot
🚷 view threshold		223.00
(+0.82%)		226.22
(98.58%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27.84
(+0.91%)		28.04
(99.31%)		📈 view plot
🚷 view threshold		10,645.00
(+0.38%)		10,694.11
(99.54%)		📈 view plot
🚷 view threshold		15,504.00
(+0.44%)		15,586.06
(99.47%)		📈 view plot
🚷 view threshold		88.00
(+5.39%)		98.75
(89.12%)		📈 view plot
🚷 view threshold		340.00
(+1.37%)		342.92
(99.15%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4.49
(+2.07%)		4.57
(98.23%)		📈 view plot
🚷 view threshold		1,461.00
(-0.03%)		1,478.93
(98.79%)		📈 view plot
🚷 view threshold		2,154.00
(-0.30%)		2,185.30
(98.57%)		📈 view plot
🚷 view threshold		12.00
(+47.13%)		14.01
(85.64%)		📈 view plot
🚷 view threshold		65.00
(+3.56%)		67.41
(96.43%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14.08
(+0.43%)		14.20
(99.16%)		📈 view plot
🚷 view threshold		5,064.00
(-0.01%)		5,081.93
(99.65%)		📈 view plot
🚷 view threshold		7,318.00
(-0.11%)		7,353.03
(99.52%)		📈 view plot
🚷 view threshold		43.00
(+18.34%)		48.07
(89.45%)		📈 view plot
🚷 view threshold		187.00
(+0.53%)		190.91
(97.95%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22.95
(+1.12%)		23.04
(99.63%)		📈 view plot
🚷 view threshold		8,040.00
(+0.10%)		8,057.13
(99.79%)		📈 view plot
🚷 view threshold		11,687.00
(+0.03%)		11,714.17
(99.77%)		📈 view plot
🚷 view threshold		83.00
(+9.81%)		89.50
(92.74%)		📈 view plot
🚷 view threshold		310.00
(+2.02%)		311.94
(99.38%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4.71
(+0.54%)		4.79
(98.46%)		📈 view plot
🚷 view threshold		1,502.00
(-0.03%)		1,519.93
(98.82%)		📈 view plot
🚷 view threshold		2,275.00
(-0.15%)		2,301.71
(98.84%)		📈 view plot
🚷 view threshold		12.00
(+27.15%)		15.48
(77.51%)		📈 view plot
🚷 view threshold		68.00
(+0.68%)		70.06
(97.06%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16.23
(+0.48%)		16.32
(99.46%)		📈 view plot
🚷 view threshold		5,963.00
(-0.01%)		5,980.93
(99.70%)		📈 view plot
🚷 view threshold		8,650.00
(-0.16%)		8,692.98
(99.51%)		📈 view plot
🚷 view threshold		53.00
(+31.47%)		55.49
(95.52%)		📈 view plot
🚷 view threshold		209.00
(+0.38%)		212.03
(98.57%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35.81
(+0.61%)		35.94
(99.65%)		📈 view plot
🚷 view threshold		14,888.00
(+0.15%)		14,917.14
(99.80%)		📈 view plot
🚷 view threshold		21,867.00
(+0.12%)		21,916.29
(99.78%)		📈 view plot
🚷 view threshold		108.00
(+15.08%)		118.28
(91.31%)		📈 view plot
🚷 view threshold		383.00
(+0.91%)		385.57
(99.33%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🐰 Bencher Report

Branchfix-release-libs-toolchain
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
1e3 x estimated cycles
(Result Δ%)		Upper Boundary
1e3 x estimated cycles
(Limit %)		InstructionsBenchmark Result
1e3 x instructions
(Result Δ%)		Upper Boundary
1e3 x instructions
(Limit %)		L1 AccessesBenchmark Result
1e3 x accesses
(Result Δ%)		Upper Boundary
1e3 x accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8.41
(-0.46%)		8.67
(97.03%)		📈 view plot
🚷 view threshold		3.66
(-1.73%)		3.86
(94.87%)		📈 view plot
🚷 view threshold		5.11
(-2.10%)		5.45
(93.82%)		📈 view plot
🚷 view threshold		10.00
(+20.53%)		15.91
(62.86%)		📈 view plot
🚷 view threshold		93.00
(+1.94%)		96.42
(96.45%)
get_submit📈 view plot
🚷 view threshold		95.32
(-0.05%)		95.63
(99.67%)		📈 view plot
🚷 view threshold		59.26
(-0.25%)		59.71
(99.26%)		📈 view plot
🚷 view threshold		85.08
(-0.29%)		85.82
(99.14%)		📈 view plot
🚷 view threshold		46.00
(+3.46%)		59.87
(76.83%)		📈 view plot
🚷 view threshold		286.00
(+1.96%)		290.98
(98.29%)
get_subscribe📈 view plot
🚷 view threshold		7.89
(-1.35%)		8.23
(95.83%)		📈 view plot
🚷 view threshold		2.76
(-2.03%)		2.94
(93.71%)		📈 view plot
🚷 view threshold		3.83
(-2.39%)		4.14
(92.54%)		📈 view plot
🚷 view threshold		13.00
(+5.12%)		20.50
(63.42%)		📈 view plot
🚷 view threshold		114.00
(-0.44%)		117.82
(96.75%)
serialize_authorize📈 view plot
🚷 view threshold		12.23
(-0.21%)		12.50
(97.84%)		📈 view plot
🚷 view threshold		5.24
(-1.15%)		5.43
(96.58%)		📈 view plot
🚷 view threshold		7.28
(-1.43%)		7.60
(95.75%)		📈 view plot
🚷 view threshold		11.00
(+9.32%)		18.61
(59.10%)		📈 view plot
🚷 view threshold		140.00
(+1.56%)		142.75
(98.08%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24.67
(-0.16%)		25.18
(97.98%)		📈 view plot
🚷 view threshold		9.79
(-0.75%)		10.01
(97.76%)		📈 view plot
🚷 view threshold		13.78
(-0.93%)		14.17
(97.25%)		📈 view plot
🚷 view threshold		36.00
(+0.39%)		45.84
(78.53%)		📈 view plot
🚷 view threshold		306.00
(+0.85%)		313.19
(97.70%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30.27
(-0.19%)		30.72
(98.52%)		📈 view plot
🚷 view threshold		11.99
(-0.53%)		12.19
(98.38%)		📈 view plot
🚷 view threshold		16.95
(-0.67%)		17.29
(98.00%)		📈 view plot
🚷 view threshold		60.00
(+7.53%)		67.45
(88.95%)		📈 view plot
🚷 view threshold		372.00
(+0.29%)		379.10
(98.13%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126.55
(+0.08%)		126.78
(99.82%)		📈 view plot
🚷 view threshold		73.12
(-0.19%)		73.53
(99.44%)		📈 view plot
🚷 view threshold		104.76
(-0.24%)		105.50
(99.30%)		📈 view plot
🚷 view threshold		109.00
(+2.48%)		125.51
(86.84%)		📈 view plot
🚷 view threshold		607.00
(+1.58%)		609.41
(99.61%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27.90
(-0.05%)		28.39
(98.25%)		📈 view plot
🚷 view threshold		9.58
(-0.59%)		9.76
(98.13%)		📈 view plot
🚷 view threshold		13.52
(-0.75%)		13.84
(97.69%)		📈 view plot
🚷 view threshold		69.00
(+7.00%)		77.91
(88.57%)		📈 view plot
🚷 view threshold		401.00
(+0.46%)		409.84
(97.84%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115.31
(+0.06%)		115.71
(99.66%)		📈 view plot
🚷 view threshold		67.89
(-0.25%)		68.42
(99.24%)		📈 view plot
🚷 view threshold		97.35
(-0.31%)		98.28
(99.06%)		📈 view plot
🚷 view threshold		71.00
(+9.34%)		86.60
(81.99%)		📈 view plot
🚷 view threshold		503.00
(+2.01%)		503.52
(99.90%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23.28
(-0.20%)		23.82
(97.72%)		📈 view plot
🚷 view threshold		8.13
(-0.72%)		8.32
(97.76%)		📈 view plot
🚷 view threshold		11.42
(-0.90%)		11.74
(97.26%)		📈 view plot
🚷 view threshold		40.00
(+3.14%)		50.69
(78.91%)		📈 view plot
🚷 view threshold		333.00
(+0.44%)		342.36
(97.27%)
serialize_submit📈 view plot
🚷 view threshold		99.81
(+0.02%)		100.10
(99.71%)		📈 view plot
🚷 view threshold		61.33
(-0.22%)		61.73
(99.34%)		📈 view plot
🚷 view threshold		87.93
(-0.27%)		88.64
(99.20%)		📈 view plot
🚷 view threshold		51.00
(+6.74%)		66.32
(76.89%)		📈 view plot
🚷 view threshold		332.00
(+2.09%)		336.51
(98.66%)
serialize_subscribe📈 view plot
🚷 view threshold		11.41
(+0.06%)		11.60
(98.37%)		📈 view plot
🚷 view threshold		4.11
(-1.28%)		4.28
(95.98%)		📈 view plot
🚷 view threshold		5.69
(-1.64%)		6.00
(94.90%)		📈 view plot
🚷 view threshold		16.00
(+16.83%)		23.62
(67.75%)		📈 view plot
🚷 view threshold		161.00
(+1.63%)		164.01
(98.16%)
🐰 View full continuous benchmarking report in Bencher

@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.29%. Comparing base (d8ef9e8) to head (4d870b0).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   19.29%   19.29%           
=======================================
  Files         164      164           
  Lines       10852    10852           
=======================================
  Hits         2094     2094           
  Misses       8758     8758
Flag Coverage Δ
binary_codec_sv2-coverage 0.00% <ø> (ø)
binary_serde_sv2-coverage 3.65% <ø> (ø)
binary_sv2-coverage 5.48% <ø> (ø)
bip32_derivation-coverage 0.00% <ø> (ø)
buffer_sv2-coverage 25.02% <ø> (ø)
codec_sv2-coverage 0.01% <ø> (ø)
common_messages_sv2-coverage 0.13% <ø> (ø)
const_sv2-coverage 0.00% <ø> (ø)
error_handling-coverage 0.00% <ø> (ø)
framing_sv2-coverage 0.29% <ø> (ø)
jd_client-coverage 0.00% <ø> (ø)
jd_server-coverage 7.79% <ø> (ø)
job_declaration_sv2-coverage 0.00% <ø> (ø)
key-utils-coverage 2.39% <ø> (ø)
mining-coverage 2.51% <ø> (ø)
mining_device-coverage 0.00% <ø> (ø)
mining_proxy_sv2-coverage 0.70% <ø> (ø)
noise_sv2-coverage 4.35% <ø> (ø)
pool_sv2-coverage 1.38% <ø> (ø)
protocols 24.72% <ø> (ø)
roles 6.54% <ø> (ø)
roles_logic_sv2-coverage 8.08% <ø> (ø)
sv2_ffi-coverage 0.00% <ø> (ø)
template_distribution_sv2-coverage 0.00% <ø> (ø)
translator_sv2-coverage 9.60% <ø> (ø)
utils 25.13% <ø> (ø)
v1-coverage 2.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plebhash plebhash merged commit 78debee into stratum-mining:main Jan 7, 2025
37 checks passed
@plebhash plebhash deleted the fix-release-libs-toolchain branch January 7, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGab19 GitGab19 GitGab19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plebhash @GitGab19