-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make api
as a separate module
#749
Conversation
@@ -56,7 +56,7 @@ jobs: | |||
|
|||
- name: Install operator-sdk | |||
run: | | |||
RELEASE_VERSION=v1.14.0 | |||
RELEASE_VERSION=v1.29.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version(v1.14.0) will cause an error while run make redhat-certificated-bundle
Generating kustomize files in config/manifests
-: pattern /home/runner/work/function-mesh/function-mesh/api/...: main module (github.com/streamnative/function-mesh) does not contain package github.com/streamnative/function-mesh/api/compute/v1alpha1
FATA[0000] Error generating kustomize files: error getting ClusterServiceVersion base: error generating ClusterServiceVersion definitions metadata: one or more API packages had type errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any error from make bundle
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has same error if use v1.14.0, all caused by command:
operator-sdk generate kustomize manifests -q
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce it, could you please delete the bundle
directory and try again to see if any error occurs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's same error, did you run the command with this PR or on master branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also confused as to why the RELEASE_VERSION
of the operator has to get updated with this but the code change itself seems fine. cc @freeznet if you have a different opinion please mark a review here requesting changes.
the |
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #745
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)