Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add KMS IAM binding #45

Merged
merged 4 commits into from
May 13, 2024
Merged

fix: Add KMS IAM binding #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
649e9a4
Added required kms_iam_binding for gke encryption
dpappa May 10, 2024
86d2af2
Added docs
dpappa May 10, 2024
45f32ca
Updated the project argument
dpappa May 10, 2024
700ad1c
Merge branch 'master' into dpappa/add-kms-sa
dpappa May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ tf apply
| [kubernetes_storage_class.sn_default](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/storage_class) | resource |
| [kubernetes_storage_class.sn_ssd](https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/resources/storage_class) | resource |
| [google_compute_zones.available](https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/compute_zones) | data source |
| [google_project.number](https://registry.terraform.io/providers/hashicorp/google/latest/docs/data-sources/project) | data source |

## Inputs

Expand Down
13 changes: 13 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ data "google_compute_zones" "available" {
project = var.project_id
}

# Declared to infer the project number
data "google_project" "project" {
project_id = var.project_id
}

resource "google_kms_key_ring" "keyring" {
count = var.enable_database_encryption && var.database_encryption_key_name == "" ? 1 : 0 # Only create if the feature is enabled and the customer didn't provide a key
name = "streamnative-keyring"
Expand All @@ -29,6 +34,14 @@ resource "google_kms_crypto_key" "gke_encryption_key" {
rotation_period = "12960000s" #150 days
}

# Required for GKE to use the encryption key
resource "google_project_iam_member" "kms_iam_binding" {
count = var.enable_database_encryption ? 1 : 0 # Only create if the feature is enabled
project = var.project_id
role = "roles/cloudkms.cryptoKeyEncrypterDecrypter"
member = "serviceAccount:service-${data.google_project.project.number}@container-engine-robot.iam.gserviceaccount.com"
}

locals {

### Node Pools
Expand Down
Loading