Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Expose deletion_protection #46

Merged
merged 1 commit into from
May 13, 2024
Merged

fix: Expose deletion_protection #46

merged 1 commit into from
May 13, 2024

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented May 11, 2024

deletion_protection is a new feature since 29.0, need to be set to false before terraform destroy

@ciiiii ciiiii requested a review from a team as a code owner May 11, 2024 15:54
@maxsxu
Copy link
Member

maxsxu commented May 12, 2024

This PR can address this comment

@ciiiii ciiiii merged commit 5052bdb into master May 13, 2024
3 checks passed
@ciiiii ciiiii deleted the yscai/deletion-protection branch May 13, 2024 07:49
@github-actions github-actions bot mentioned this pull request May 13, 2024
Merged
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxsxu maxsxu maxsxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciiiii @maxsxu