Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support private nodes on public GKE #57

Merged
merged 4 commits into from
Dec 5, 2024
Merged

feat: Support private nodes on public GKE #57

merged 4 commits into from
Dec 5, 2024

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Dec 4, 2024

  • upgrade GKE module to 30.3.0
    • Specify autoscaling_profile in cluster_autoscaling_config
  • Specify pod_range in node_pools by default, it's a limitation in upstream module, otherwise enable_private_nodes won't take effect

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/50c1a420179df3a7c596c93f8ecc05a207276aa1/cluster.tf#L478-L484

@ciiiii ciiiii requested a review from a team as a code owner December 4, 2024 12:05
@ciiiii ciiiii changed the title Support private nodes on public GKE feat: Support private nodes on public GKE Dec 4, 2024
@ciiiii ciiiii merged commit beff464 into master Dec 5, 2024
3 of 4 checks passed
@ciiiii ciiiii deleted the yscai/private-nodes branch December 5, 2024 04:05
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitch-hamm mitch-hamm mitch-hamm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciiiii @mitch-hamm