feat(cli-tools): Add internal operator and sponsorship commands #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o be compatible with StreamrClient#getSigner()
teogeb
force-pushed
the
cli-tools-internal-operator-and-sponsorship-commands
branch
from
10f6e88 to
b351c5f
Compare
jtakalai
approved these changes
Jan 16, 2025
teogeb
added a commit
to streamr-dev/network-contracts
that referenced
this pull request
Jan 17, 2025
… value (#949) The new value is one second. This is better value for development environment (see e.g. use case in streamr-dev/network#2926).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs streamr-dev/network-contracts#949 (and a new
dev-chain-fastDocker image generated which contains that feature).Added these internal commands:
sponsorship-sponsoroperator-delegateoperator-undelegateoperator-stakeoperator-unstakeAPI
The token amounts are given in full DATA tokens, not in DATA token weis. This is maybe a good approach for end-user tools like this.
Other changes
Ractored some
operatorContractUtilsmethod signatures: user authentication is passed asSignerWithProviderinstead ofWallet, so thatclient.getSigner()can be used as an argument. These are internal methods, i.e. this is not a breaking change.Future improvements
These commands could be normal CLI tools commands, i.e. just not for the internal use. That would be possible if we add support for
DataV2token to the SDK. Currently the only token contract available foroperatorContractUtilsis the test token contract. (Note that most likely there is no need to have both theDataV2andTestToken, asDataV2can be used also for tests.)