-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Complete Prettier setup #2966
base: main
Are you sure you want to change the base?
Conversation
What do mean by this? Could we configure the |
@teogeb, Prettier formats code according to its opinionated rules, and conflicts can arise if ESLint's |
Is the plan the add a separate Prettier task to the CI which checks that the code is formatted using our style? (I.e. that we'd run If that's the case, it may be ok to remove the duplicated check from Another alternative would be to automatically format the code in the CI using Prettier, or otherwise enforce that all code is formatted using it. But that approach has other downsides, and maybe that's not our intention? |
It's a bit complicated but yeah, to me the new check seem desirable. Why complicated? All files would have to be formatted before we introduce the check. Easy in a small project but for us.. well, we have to coordinate because all open PRs *will* suffer a "cosmetic" conflict situation. One way to apprach open PRs, assuming the
Well, one can naturally just merge in |
Eslint's `indent` rule conflicts with prettier's behaviour.
Since
.prettierrc
is already there… In this PR I complete Prettier's config and make it intertwine with eslint better. Cosmetic change.Changes
indent
because it conflicts with Prettier..prettierrc
to.prettierrc.json
so it can be formatted using json formatting rules (by Prettier itself).Limitations and future improvements
Checklist before requesting a review
TODO
comments left behind are meant to be left in.