Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(network, dht): NET-1392 rename source to remote in appropriate places #2970

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

juslesan
Copy link
Contributor

Summary

Renamed references from source to remote in appropriate places. Using the source/target pattern makes sense if there is a need to indicate clearly who is sending and who is receiving. If the sender and receiver is already implicitly known it makes more sense to use remote/local

Future improvements

  • Go over places where the source naming convention is used.
    • For example: In the routing wrappers the source is called sourcePeer. It could make more sense to name it just source. This holds true for any other places where we use ie sourcePeerDescriptor. As the type is known there is no need to include it in the name.
  • Rename source to originator? IMO this is not a necessary change since both words have the same meaning in this context

Copy link

linear bot commented Jan 10, 2025

@github-actions github-actions bot added network Related to Network Package dht Related to DHT package labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dht Related to DHT package network Related to Network Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant