-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Updates lookup call to use mobile endpoint on verified flows #9820
Merged
carlosmuvi-stripe
merged 1 commit into
master
from
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
Jan 15, 2025
Merged
[FC] Updates lookup call to use mobile endpoint on verified flows #9820
carlosmuvi-stripe
merged 1 commit into
master
from
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
Diffuse output:
APK
DEX
|
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 10:31
65fa3c3
to
5da26c9
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 10:31
22a9cb4
to
366a2a5
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 10:41
5da26c9
to
ecc939b
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 10:41
366a2a5
to
c75c7df
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 10:47
ecc939b
to
30a830a
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 10:47
c75c7df
to
152856f
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 11:52
30a830a
to
b87210e
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 11:52
152856f
to
2cd4451
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:04
b87210e
to
b2bb731
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 12:04
2cd4451
to
14220fb
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:12
b2bb731
to
c053783
Compare
3 tasks
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 12:12
14220fb
to
56c663c
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:17
c053783
to
03c604c
Compare
carlosmuvi-stripe
changed the title
Updates lookup call to use mobile endpoint on verified flows
[FC] Updates lookup call to use mobile endpoint on verified flows
Dec 23, 2024
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 12:17
56c663c
to
cd2aa80
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 14:27
03c604c
to
eed6066
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 14:27
cd2aa80
to
4657230
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 14:28
eed6066
to
ade027d
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 14:28
4657230
to
3c39a07
Compare
...ipe/android/financialconnections/repository/FinancialConnectionsConsumerSessionRepository.kt
Show resolved
Hide resolved
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
December 23, 2024 15:27
06ad79c
to
d45c6e2
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 24, 2024 13:08
ade027d
to
60ad1f8
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
2 times, most recently
from
December 24, 2024 15:18
dc1ba2a
to
8886acf
Compare
payments-model/src/main/java/com/stripe/android/repository/ConsumersApiService.kt
Outdated
Show resolved
Hide resolved
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 9, 2025 04:59
38f8f9d
to
f5ed9fe
Compare
.../src/main/java/com/stripe/android/financialconnections/FinancialConnectionsSheetViewModel.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/com/stripe/android/financialconnections/FinancialConnectionsSheetViewModel.kt
Outdated
Show resolved
Hide resolved
...ions/src/main/java/com/stripe/android/financialconnections/domain/IntegrityVerdictManager.kt
Show resolved
Hide resolved
...connections/src/main/java/com/stripe/android/financialconnections/features/error/ErrorExt.kt
Outdated
Show resolved
Hide resolved
...connections/src/main/java/com/stripe/android/financialconnections/features/error/ErrorExt.kt
Outdated
Show resolved
Hide resolved
...cial-connections/src/main/java/com/stripe/android/financialconnections/domain/HandleError.kt
Outdated
Show resolved
Hide resolved
...ancialconnections/features/networkinglinkverification/NetworkingLinkVerificationViewModel.kt
Outdated
Show resolved
Hide resolved
payments-model/src/main/java/com/stripe/android/repository/ConsumersApiService.kt
Outdated
Show resolved
Hide resolved
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 17:12
0112b88
to
31c0f8f
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 10, 2025 17:12
f5ed9fe
to
01c70ae
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 17:35
31c0f8f
to
19bb247
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 10, 2025 17:35
01c70ae
to
588dc52
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 18:24
19bb247
to
383d472
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 10, 2025 18:24
588dc52
to
04a72b2
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
2 times, most recently
from
January 10, 2025 20:39
a112049
to
9332cd6
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 10, 2025 20:39
04a72b2
to
d6efaca
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 21:05
9332cd6
to
ad9e8a8
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
2 times, most recently
from
January 11, 2025 01:16
7d91d37
to
23f701f
Compare
carlosmuvi-stripe
changed the base branch from
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
to
graphite-base/9820
January 13, 2025 14:08
carlosmuvi-stripe
force-pushed
the
graphite-base/9820
branch
from
January 13, 2025 14:08
ad9e8a8
to
0087322
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 13, 2025 14:08
23f701f
to
d657b0d
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
3 times, most recently
from
January 14, 2025 00:25
556a725
to
f94a7db
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 14, 2025 18:07
f94a7db
to
0acfafe
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
from
January 14, 2025 22:23
0acfafe
to
bdcf9f7
Compare
...inancialconnections/features/networkinglinkloginwarmup/NetworkingLinkLoginWarmupViewModel.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Two notes:
- I’m wondering how process death during the bank auth would impact this. Let’s discuss this in Slack.
- We should add a toggle to mock an integrity verdict failure, which would allow us to test this much better (think Maestro test).
tillh-stripe
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked and decided to do the two mentioned things as follow-ups to this pull request.
carlosmuvi-stripe
deleted the
carlosmuvi/12-22-updates_lookup_call_to_use_mobile_endpoint_on_verified_flows
branch
January 15, 2025 19:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mobile/lookup
on verified flows.session_id
andemail_source
, optional before, are now required.POST consumer_sessions
(does some method renaming to match this)ErrorHandler
to, on attestation failures, close the native AuthFlow and continue on web.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy
Testing