Adds app verification fields in FC manifest and synchronize call #4452
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚨 New dead code detected in this PR: FinancialConnectionsSessionManifest.swift:130 warning: Initializer 'init(accountholderCustomerEmailAddress:accountholderIsLinkConsumer:accountholderPhoneNumber:accountholderToken:accountDisconnectionMethod:activeAuthSession:activeInstitution:allowManualEntry:appVerificationEnabled:assignmentEventId:businessName:cancelUrl:consentRequired:customManualEntryHandling:disableLinkMoreAccounts:displayText:experimentAssignments:features:hostedAuthUrl:initialInstitution:instantVerificationDisabled:institutionSearchDisabled:isEndUserFacing:isLinkWithStripe:isNetworkingUserFlow:isStripeDirect:livemode:manualEntryMode:manualEntryUsesMicrodeposits:nextPane:paymentMethodType:permissions:product:singleAccount:skipSuccessPane:stepUpAuthenticationRequired:successUrl:_theme:)' is unusedPlease remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
carlosmuvi-stripe
approved these changes
Jan 9, 2025
| @@ -80,6 +80,7 @@ struct FinancialConnectionsSessionManifest: Decodable { | |||
| let activeAuthSession: FinancialConnectionsAuthSession? | |||
| let activeInstitution: FinancialConnectionsInstitution? | |||
| let allowManualEntry: Bool | |||
| let appVerificationEnabled: Bool? | |||
There was a problem hiding this comment.
Made this to never be null backend side, but let's keep it optional to keep API flexibility
There was a problem hiding this comment.
Sounds good! I was matching the backend model.
Comment on lines
+310
to
+311
| let attest = backingAPIClient.stripeAttest | ||
| if attest.isSupported { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
appVerificationEnabledfield to the Financial Connections manifest model.mobile[supports_app_verification]andmobile[verified_app_id]parameters to the/synchronizeendpoint if app attestation is supported.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?usp=sharing
Testing
Manual testing
Changelog
N/a