Fixes #306

structurizr · Jun 18, 2024 · b4211a9 · b4211a9
1 parent 7460200
commit b4211a9
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 6 deletions.
diff --git a/build.gradle b/build.gradle
@@ -8,7 +8,7 @@ subprojects { proj ->
 
     description = 'Structurizr'
     group = 'com.structurizr'
-    version = '2.1.3'
+    version = '2.1.4'
 
     repositories {
         mavenCentral()

diff --git a/changelog.md b/changelog.md
@@ -1,8 +1,13 @@
 # Changelog
 
+
+## 2.1.4 (18th June 2024)
+
+- structurizr-core: Fixes https://github.com/structurizr/java/issues/306 (Workspace.trim() is not correctly removing relationships when the destination of a relationship is removed from the workspace).
+
 ## 2.1.3 (16th June 2024)
 
-- structurizr-core: Fixes https://github.com/structurizr/java/issues/298 (Unknown model item type on 'element')
+- structurizr-core: Fixes https://github.com/structurizr/java/issues/298 (Unknown model item type on 'element').
 
 ## 2.1.2 (30th April 2024)
 

diff --git a/structurizr-core/src/main/java/com/structurizr/model/Model.java b/structurizr-core/src/main/java/com/structurizr/model/Model.java
@@ -1149,12 +1149,9 @@ private void removeElement(Element element) {
 
         // remove any relationships to/from the element
         for (Relationship relationship : getRelationships()) {
-            if (relationship.getSource() == element) {
+            if (relationship.getSource() == element || relationship.getDestination() == element) {
                 removeRelationshipFromInternalStructures(relationship);
                 relationship.getSource().remove(relationship);
-            } else if (relationship.getDestination() == element) {
-                removeRelationshipFromInternalStructures(relationship);
-                relationship.getDestination().remove(relationship);
             }
         }
 

diff --git a/structurizr-core/src/test/java/com/structurizr/WorkspaceTests.java b/structurizr-core/src/test/java/com/structurizr/WorkspaceTests.java
@@ -285,4 +285,19 @@ void trim_WhenSomeElementsAreUnused() {
         assertTrue(workspace.getModel().contains(bc));
     }
 
+    @Test
+    void trim_WhenTheDestinationOfAnElementIsRemoved() {
+        Workspace workspace = new Workspace("Name", "Description");
+        SoftwareSystem a = workspace.getModel().addSoftwareSystem("A");
+        SoftwareSystem b = workspace.getModel().addSoftwareSystem("B");
+        a.uses(b, "Uses");
+
+        SystemLandscapeView view = workspace.getViews().createSystemLandscapeView("key", "Description");
+        view.add(a);
+
+        workspace.trim();
+
+        assertEquals(0, a.getRelationships().size());
+    }
+
 }