-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: Add CI workflow to run tests #62
Conversation
This reverts commit cf8635e.
Tests/NetworkingTests/EndpointRequestStorageProcessorTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving few more questions/comments Ω
...g/Modifiers/Processors/EndpointRequestStorageProcessor/EndpointRequestStorageProcessor.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝
@matejmolnar @cejanen I hope you noticed but just to be sure that you've seen results that were added as part of this PR as well 😄 |
@cejanen @matejmolnar Few more changes added in the tests. Let's have a look again please. Possibly the last review 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
Changes:
master
swift test
instead ofxcodebuild
which is faster twice fasterLimitations:
swift test
because the loading of files fails (resources are handled differently when runningswift test
vsxcodebuild
). When runningswift test
they are not compiled intoAssets.car
which might be the reason why we are unable to load the file viaNSDataAsset
(inMockResponseProvider
) but I haven't debugged that far to know that for sure.