Skip to content

Commit

Permalink
fix(cmake): NO_EXTRAS in pybind11_add_module function partially w…
Browse files Browse the repository at this point in the history
…orking (pybind#5378)
  • Loading branch information
Hintay authored Sep 19, 2024
1 parent ad9fd39 commit 1f8b4a7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tools/pybind11NewTools.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,6 @@ function(pybind11_add_module target_name)
target_link_libraries(${target_name} PRIVATE pybind11::embed)
endif()

if(MSVC)
target_link_libraries(${target_name} PRIVATE pybind11::windows_extras)
endif()

# -fvisibility=hidden is required to allow multiple modules compiled against
# different pybind versions to work properly, and for some features (e.g.
# py::module_local). We force it on everything inside the `pybind11`
Expand Down

0 comments on commit 1f8b4a7

Please sign in to comment.