Aads cargo chef to docker build for rust template #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuler
reviewed
Mar 19, 2024
tuler
reviewed
Mar 20, 2024
rust/Dockerfile
Outdated
| busybox-static=1:1.30.1-7ubuntu3 \ | ||
| ca-certificates=20230311ubuntu0.22.04.1 \ | ||
| curl=7.81.0-1ubuntu1.15 | ||
| curl -fsSL https://github.com/cartesi/machine-emulator-tools/releases/download/v${MACHINE_EMULATOR_TOOLS_VERSION}/machine-emulator-tools-v${MACHINE_EMULATOR_TOOLS_VERSION}.tar.gz \ |
There was a problem hiding this comment.
Please take a look at the other templates in the main branch.
We switched to use ADD instead of curl.
Just for consistency.
There was a problem hiding this comment.
Nice that is much cleaner. Made the change here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using sunodo for rust projects it is really slow to have to rebuild from scratch in docker every time.
Using cargo-chef this caches the build of the project dependencies and so only needs to rebuild the application itself. This makes running
sunodo buildsignificantly faster for any larger application.This also bumps the rust version to 1.76.0 as
cargo-chefdoesn't support the older version