Fix uninitalized values in Waveshaper #993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #992
1st change is needed for the case where plugin UI runs while Rack/Cardinal is bypassed which makes this:
read uninitialized values (they are only set during processing)
2nd change is more obvious, fixes the use of
displayPolyChannel
which does not have a value set.This also matches what https://cplusplus.com/reference/atomic/atomic/atomic/ says
which I didn't know it was a thing, I thought
std::atomic
types would initialize to 0...