Bridge: log svix client errors as error, not trace #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got 3 places where we log errors in the poller loop and this one somehow wound up logging as `trace!` instead of `error!` like the rest.
svix-jplatte
approved these changes
Jul 12, 2024
svix-lucho
added a commit
that referenced
this pull request
Jul 31, 2024
## What's Changed * Bridge: add `/events` poller by @svix-onelson in #1363 * server: Optimize all external host dependencies for faster rebuilds by @svix-jplatte in #1365 * Bridge: log svix client errors as error, not trace by @svix-onelson in #1368 * Bump Cargo lockfiles by @svix-jplatte in #1370 * server: add configuration to for changing service name on OpenTelemetry by @LeoZ100 in #1371 * build(deps): bump openssl from 0.10.64 to 0.10.66 in /bridge by @dependabot in #1372 * bridge: Require type field for kafka input, output by @svix-jplatte in #1374 * Bump OpenAPI spec and regenerate libs by @svix-lucho in #1375 ## New Contributors * @LeoZ100 made their first contribution in #1371 **Full Changelog**: v1.25.0...v1.26.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got 3 places where we log errors in the poller loop and this one somehow wound up logging as
trace!instead oferror!like the rest.Follow-on from #1363