Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript @ts-ignore: window, navigator #3768

Merged
merged 8 commits into from
Dec 9, 2020

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Dec 7, 2020

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming, keep simple
  • Tested desktop/mobile
  • Tested bright/dark
  • Tested en/ru
  • Affects money; I checked the functionality once again
  • I checked the PR once again

Original issue

#3562

common/web3connect

  • Проверить getInjectedType()
  • Проверить isConnected()

@Disti4ct Disti4ct changed the title TypeScript @ts-ignore: window TypeScript @ts-ignore: window, navigator Dec 7, 2020
@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

src/front/global.d.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@shendel shendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Описать интерфейс EthereumObject, убрать "the keys in brackets because typescript shows an error" (https://github.com/swaponline/MultiCurrencyWallet/pull/3768/files#diff-d8413777e5a479ca969135190804780fabc157d85e483ae22ab8a32db085408eR20)

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@sorentobot
Copy link
Collaborator

@Disti4ct Disti4ct merged commit 6c22c92 into swaponline:master Dec 9, 2020
@Disti4ct Disti4ct deleted the tsIgnoreWindow branch December 9, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants