Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension: fail on external wallet connection. TS: @ts-gnore cleanup #4828

Merged
merged 6 commits into from
Oct 1, 2021

Conversation

Disti4ct
Copy link
Collaborator

@Disti4ct Disti4ct commented Sep 30, 2021

Checklist

  • I have read the CONTRIBUTING guide
  • Good naming (as clear and simple as possible)
  • Correct behavior if external API endpoints are down, return 404, 504 (or no answer), 401 errors (ddos simulation)
  • I tested desktop/mobile resolution
  • I tested light/dark theme
  • I tested different languages
  • I checked the functionality once again (AFFECT MONEY)
  • I checked the work on the Testnet
  • I checked the work on the Mainnet
  • I checked the work in the plugin
  • I checked the PR once again

Tests

Please start auto tests as follows:

  • add a label swap test to start swap tests
  • add a label withdraw test to start withdraw tests

You can skip these tests if you completely sure that your changes aren't related to this functional

Original issue

#3562

Video / screenshot proof

@noxonsu
Copy link
Member

noxonsu commented Sep 30, 2021

в екстеншине пока не нужно вообще коннект валета, т.к. в этом случае маркетмейкер может тупить

@noxonsu
Copy link
Member

noxonsu commented Sep 30, 2021

сюда же еще убрать этот текст про APY https://screenshots.wpmix.net/chrome_6lYoTVhfzPwwnlUJz0Su28Qry8miI7i6.png
и вернуть переключалку на другие валюты как в онлайне видны серые

@Disti4ct
Copy link
Collaborator Author

Disti4ct commented Oct 1, 2021

сюда же еще убрать этот текст про APY https://screenshots.wpmix.net/chrome_6lYoTVhfzPwwnlUJz0Su28Qry8miI7i6.png и вернуть переключалку на другие валюты как в онлайне видны серые

они есть. Если не видно, значит в кошельке нет токенов

@noxonsu
Copy link
Member

noxonsu commented Oct 1, 2021

сюда же еще убрать этот текст про APY https://screenshots.wpmix.net/chrome_6lYoTVhfzPwwnlUJz0Su28Qry8miI7i6.png и вернуть переключалку на другие валюты как в онлайне видны серые

они есть. Если не видно, значит в кошельке нет токенов

у меня есть btcb но не показывает

@Disti4ct
Copy link
Collaborator Author

Disti4ct commented Oct 1, 2021

тесты не проходят только из-за биткоина без баланса

@Disti4ct Disti4ct changed the title (WIP) Extension: fail on external wallet connection. TS: @ts-gnore cleanup Extension: fail on external wallet connection. TS: @ts-gnore cleanup Oct 1, 2021
@noxonsu noxonsu merged commit c9ebf32 into swaponline:master Oct 1, 2021
@noxonsu
Copy link
Member

noxonsu commented Oct 1, 2021

блин забыли поменять версию екстеншина

@Disti4ct Disti4ct deleted the browserExtension branch October 1, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants