-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md with names of new maintainers #259
base: main
Are you sure you want to change the base?
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/matlab-novice-inflammation/compare/md-outputs..md-outputs-PR-259 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-11-14 11:33:46 +0000 |
This pull request now also relates to and closes #258 |
Hi @quirksahern, thank you for opening this pull request! Apologies for the delay in looking at this, what with the busy year-end period and all. Please feel free to mark me as a reviewer for any future pull requests in this repository. I notice this PR contains a commit related to the issue you have opened related to array indexing in MATLAB. Would you mind reverting that commit so that we can separate the concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a couple of suggestions regarding links to maintainer pages, but otherwise the changes to the readme look good.
- Daniel Cummins | ||
- Padem dhar Dwivedi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Daniel Cummins | |
- Padem dhar Dwivedi | |
- [Daniel Cummins](https://github.com/dc2917) | |
- [Padem dhar Dwivedi](https://github.com/padmdhar15ald) |
|
||
[lesson-example]: https://carpentries.github.io/lesson-example | ||
|
||
Previous Maintainer: | ||
[capes_gerard]: https://software-carpentry.org/team/#capes_gerard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[capes_gerard]: https://software-carpentry.org/team/#capes_gerard | |
- Gerard Capes |
That link is now broken, so let's just use their name
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
If any relevant discussions have taken place elsewhere, please provide links to these.
For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.
Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at [email protected].
Relates to #256 - current maintainers now listed, unable to find GH handles.