address yuxia's comments

swuferhong · Dec 13, 2024 · b327904 · b327904
1 parent 4618fa7
commit b327904
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/fluss-client/src/main/java/com/alibaba/fluss/client/lookup/LookupSender.java b/fluss-client/src/main/java/com/alibaba/fluss/client/lookup/LookupSender.java
@@ -201,12 +201,12 @@ private void handleLookupResponse(
             LookupBatch lookupBatch = lookupsByBucket.get(tableBucket);
             if (pbLookupRespForBucket.hasErrorCode()) {
                 // TODO for re-triable error, we should retry here instead of throwing exception.
+                ApiError error = ApiError.fromErrorMessage(pbLookupRespForBucket);
                 LOG.warn(
                         "Get error lookup response on table bucket {}, fail. Error: {}",
                         tableBucket,
-                        pbLookupRespForBucket.getErrorMessage());
-                lookupBatch.completeExceptionally(
-                        new FlussRuntimeException(pbLookupRespForBucket.getErrorMessage()));
+                        error.formatErrMsg());
+                lookupBatch.completeExceptionally(error.exception());
             } else {
                 List<PbValue> pbValues = pbLookupRespForBucket.getValuesList();
                 lookupBatch.complete(pbValues);

diff --git a/fluss-client/src/test/java/com/alibaba/fluss/client/table/FlussTableITCase.java b/fluss-client/src/test/java/com/alibaba/fluss/client/table/FlussTableITCase.java
@@ -222,7 +222,8 @@ void testLookupForNotReadyTable() throws Exception {
                 TableDescriptor.builder().schema(DATA1_SCHEMA_PK).distributedBy(10).build();
         long tableId = createTable(tablePath, descriptor, true);
         IndexedRow rowKey = keyRow(DATA1_SCHEMA_PK, new Object[] {1, "a"});
-        // retry until all replica ready. Otherwise, the lookup maybe fail.
+        // retry until all replica ready. Otherwise, the lookup maybe fail. To avoid test unstable,
+        // if you want to test the lookup for not ready table, you can comment the following line.
         waitAllReplicasReady(tableId, descriptor);
         Table table = conn.getTable(tablePath);
         assertThat(lookupRow(table, rowKey)).isNull();