Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update es mapper #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update es mapper #139

wants to merge 2 commits into from

Conversation

mpicel
Copy link

@mpicel mpicel commented Dec 8, 2022

Revise es mapper to walk nested objects defined in schema file. This will prevent us from relying on dynamic mapping for nested objects.

@mpicel mpicel requested a review from paulcruse-syn as a code owner December 8, 2022 19:33
ncgl-syngenta
ncgl-syngenta requested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@ncgl-syngenta ncgl-syngenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add functionality that creates a key as a keyword if the key is an id? this will allow for exact matching on ids, instead of returning similiar ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncgl-syngenta ncgl-syngenta ncgl-syngenta requested changes

@paulcruse-syn paulcruse-syn Awaiting requested review from paulcruse-syn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpicel @ncgl-syngenta