[feature] Note To Self #569

EdGeraghty · 2022-02-15T18:36:27Z

Types

Fix (non-breaking change which fixes an issue)
Feature (non-breaking change which adds functionality)
Refactor (non-breaking change which improves code quality - QA thoroughly )
Breaking Change (fix or feature that would cause existing functionality to not work as expected)
Chore (updates that would not affect or change the code involving the app itself)

Changes

🔮 Features

Notes to Self

🐛 Fixes

🔒 Security

🛠 Performance

📐 Refactoring

Media (if applicable)

QA

Final Checklist

All associated issues have been linked to PR
All necessary changes made to the documentation
Parties interested in these changes have been notified

EdGeraghty

flutter: [🌎 Easy Localization] [DEBUG] Build
flutter: [🌎 Easy Localization] [DEBUG] Init Localization Delegate
flutter: [🌎 Easy Localization] [DEBUG] Init provider
flutter: [🌎 Easy Localization] [DEBUG] Load Localization Delegate
flutter: [🌎 Easy Localization] [DEBUG] Load asset from assets/translations
flutter: [🌎 Easy Localization] [DEBUG] Load asset from assets/translations
flutter: [media] loaded 0
flutter: [initStore] persistor saving from SetOlmAccount
flutter: [initStore] persistor saving from SetDeviceKeysOwned
flutter: [syncObserver] running sync
flutter: [fetchSync] *** starting sync *** 
flutter: createHttpClient() - cert already trusted! Skipping.
flutter: [updateOneTimeKeyCounts] {signed_curve25519: 35}, current {signed_curve25519: 35}
flutter: [syncObserver] running sync
flutter: [fetchSync] *** starting sync *** 
flutter: createHttpClient() - cert already trusted! Skipping.
flutter: [syncObserver] still syncing
flutter: [syncObserver] still syncing
flutter: [parseSync] !UVfspReCNKmqemGPlZ:geraghty.london limited true lastBatch false prevBatch true
flutter: [syncRooms] Empty Chat full_synced: true limited: false total new messages: 0 roomPrevBatch: s147361_12212344_4663_212358_8049_9_1968_488751_1
flutter: [initStore] persistor saving from SetRoom
flutter: [updateOneTimeKeyCounts] {signed_curve25519: 35}, current {signed_curve25519: 35}
flutter: [toggleDirectRoom] Account data not found
flutter: [syncRooms] Note to Self full_synced: true limited: false total new messages: 0 roomPrevBatch: s147361_12212344_4663_212358_8049_9_1968_488751_1
flutter: [initStore] persistor saving from SetRoom
flutter: [initStore] persistor saving from SetRoom
flutter: createHttpClient() - cert already trusted! Skipping.
flutter: [syncObserver] running sync
flutter: [fetchSync] *** starting sync *** 
flutter: [syncRooms] Note to Self full_synced: true limited: false total new messages: 0 roomPrevBatch: t1-147360_0_0_0_0_0_0_0_0
flutter: createHttpClient() - cert already trusted! Skipping.
flutter: [parseSync] !UVfspReCNKmqemGPlZ:geraghty.london limited false lastBatch false prevBatch true
flutter: [syncRooms] Note to Self full_synced: true limited: false total new messages: 0 roomPrevBatch: s147362_12212344_4663_212358_8049_9_1968_488751_1
flutter: [initStore] persistor saving from SetRoom
flutter: [syncObserver] still syncing
flutter: [initStore] persistor saving from SetRoom
flutter: [updateOneTimeKeyCounts] {signed_curve25519: 35}, current {signed_curve25519: 35}
flutter: [syncObserver] running sync
flutter: [fetchSync] *** starting sync *** 
flutter: createHttpClient() - cert already trusted! Skipping.
flutter: [syncObserver] still syncing
flutter: [syncObserver] still syncing
flutter: [sendTyping] typing indicators disabled
flutter: [syncObserver] still syncing
flutter: [claimOneTimeKeys] all key sharing sessions per device are ready
flutter: [loadKeySessionOutbound] checking outbounds for /L3LKf+xndwccTHRrADDPJ+M8s9ixfn5MG/aNQzoJjU
flutter: [loadKeySessionOutbound] found mm4XMVCtlS/droRSSu9yEVk4Se60BIpdnqQGpGfkaFs for /L3LKf+xndwccTHRrADDPJ+M8s9ixfn5MG/aNQzoJjU of type 0
flutter: [loadKeySessionOutbound] checking outbounds for Jq4UBW9A+vYuEHYU/3q87rs+eKSG4/B0gW+UMTB4DXs
flutter: [loadKeySessionOutbound] found IH9lsrA/fbgeWxb1BLh6bQaE9iqRYRMNFFF6arwtmEQ for Jq4UBW9A+vYuEHYU/3q87rs+eKSG4/B0gW+UMTB4DXs of type 0
flutter: [loadKeySessionOutbound] checking outbounds for 9Zw8kLtAKBDgmmId7huJ4/guY2D8nRWPRFasMp8T/wo
flutter: [loadKeySessionOutbound] found XU+Jd6iPYVYpTXyNh5cMxf6ESzp1Hi1Vx8pk4Oykjsg for 9Zw8kLtAKBDgmmId7huJ4/guY2D8nRWPRFasMp8T/wo of type 0
flutter: [loadKeySessionOutbound] checking outbounds for htTpjuaJe0FvyHQ3YWl+2oHwBQJ2pNUmUvNNBYbwo08
flutter: [loadKeySessionOutbound] found G68XN2FhgtAMfk+gvHLBWtMADdayrAHiq0kFQgin4QE for htTpjuaJe0FvyHQ3YWl+2oHwBQJ2pNUmUvNNBYbwo08 of type 0
flutter: [loadKeySessionOutbound] checking outbounds for l695NaXBcdagrk48oB0MhvrOxu6rONTMAU9hNu4/R0A
flutter: [loadKeySessionOutbound] found Qhs4dAyVnI2YQoQcLa4MynYHfWCgE4A+MCIQj9dsu0M for l695NaXBcdagrk48oB0MhvrOxu6rONTMAU9hNu4/R0A of type 0
flutter: [loadKeySessionOutbound] checking outbounds for DczLY/nYiAbekZBYCeH104bRX6ORvoARi4JUWvUO3Aw
flutter: [loadKeySessionOutbound] found zsEjLFsnCHx4dv66Qb3ZW76hlRyqOyTeokAbGgsAJrU for DczLY/nYiAbekZBYCeH104bRX6ORvoARi4JUWvUO3Aw of type 0
flutter: [loadKeySessionOutbound] checking outbounds for 4UZmI73L3pu6U9NoUo4XRjEtUhY8AreNsHe6TT9Vwyw
flutter: [loadKeySessionOutbound] found 7kIY02/lk2tfaED1B7Eex9sI8eyenIbwKSto+ZQcZF0 for 4UZmI73L3pu6U9NoUo4XRjEtUhY8AreNsHe6TT9Vwyw of type 0
flutter: [loadKeySessionOutbound] checking outbounds for li01zcxEp1uLain2F+K1sQwoYtVr9Kmu90cwVxayckc
flutter: [loadKeySessionOutbound] found eWS1H2sAfRjHR1uJluGW2zwvGME02YlC8egSHf6eVZU for li01zcxEp1uLain2F+K1sQwoYtVr9Kmu90cwVxayckc of type 0
flutter: [loadKeySessionOutbound] checking outbounds for SuRvu6j0qpGjWXXIsUi93mmltiX0nj0qKS32u83qmCc
flutter: [loadKeySessionOutbound] found 4QTQ0G+xGvrcVAW97CYrL3NXyGlEQib+WlpXYRYZQxY for SuRvu6j0qpGjWXXIsUi93mmltiX0nj0qKS32u83qmCc of type 0
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [initStore] persistor saving from SaveKeySession
flutter: [sendSessionKeys] success! 2036539858
flutter: [sendSessionKeys] success! 1175466330
flutter: [sendSessionKeys] success! 1922827214
flutter: [sendSessionKeys] success! 1474527561
flutter: [sendSessionKeys] success! 704602701
flutter: [sendSessionKeys] success! 2123870775
flutter: [sendSessionKeys] success! 1746299933
flutter: [sendSessionKeys] success! 2066904403
flutter: [sendSessionKeys] success! 1322305846
flutter: [syncObserver] still syncing
flutter: [parseSync] !UVfspReCNKmqemGPlZ:geraghty.london limited false lastBatch false prevBatch true
flutter: [syncRooms] Note to Self full_synced: true limited: false total new messages: 1 roomPrevBatch: s147369_12212344_4663_212358_8049_9_1977_488751_1
flutter: [decryptMessage] Unable to find inbound message session for decryption
flutter: [initStore] persistor saving from SetRoom

For some reason I can't decrypt messages in a Note to Self DM room

ereio · 2022-02-16T01:40:17Z

very strange, i'll take a look. I have a feeling it's some code block associated with sending keys properly only when another non-currentUser is in the room.

EdGeraghty · 2022-02-16T16:25:20Z

Interestingly, it's also unable to decrypt messages sent by Element, although Element is perfectly happy with the room as configured. It's something to do with loadMessageSessionInbound, but I'm just chasing my tail in circles haha

EdGeraghty · 2022-02-18T16:06:39Z

I've logged out and back in, and suddenly these rooms work as expected 🤦‍♂️

ereio · 2022-02-21T02:23:18Z

@EdGeraghty can you pull the latest changes from dev? Want to see if it changes anything; it affects messageSessionInbound keys.

EdGeraghty · 2022-02-21T13:14:12Z

@ereio I have rebased on Dev and all seems good

ereio · 2022-02-22T01:07:50Z

not sure what happened with this merge but it looks like it's attempting to recommit previous work?

would you mind rebase your changes on top of dev instead? Happy to attempt doing it as well

ereio · 2022-03-18T17:25:11Z

let me know if/when you'd like me to take a look at this!

EdGeraghty · 2022-03-19T01:17:06Z

Yes - sorry, I got a little lost in the best way to implement the room avatar and then got sidetracked on other stuff.

EdGeraghty · 2022-03-30T18:47:25Z

I've rebased this and it's still working as expected. The last step is to work out how to set the room avatar - is this a good/silly approach so far?

Sadly, this throws an error...

EdGeraghty · 2022-04-20T09:53:23Z

As you can see, I'm very close but the Avatar Widget is throwing an AppState error which is what ends up being set haha

lib/views/home/search/search-users-screen.dart

EdGeraghty · 2022-04-20T13:04:11Z

I've only gone and done it...!

EdGeraghty · 2022-04-20T13:08:19Z

Fixes #560

ereio

Great work @EdGeraghty !

I'd like to make sure a few things are handled properly before merging. Have you tested what happens when a user searches themselves again after they've created a Note To Self? Does it automatically navigate them there like existing user DMs?

ereio · 2022-04-20T13:55:07Z

lib/store/rooms/actions.dart

+          inviteIds.whereNot((userId) => userId == currentUser.userId).toList();
+
+      final isNoteToSelf =
+          inviteIds.length == 1 && inviteIds.single == currentUser.userId;


good form on this line. It's a one liner, but it's easy to read

ereio · 2022-04-20T13:56:50Z

lib/store/user/selectors.dart

+  final List<User> latestUsers = List.from(users.values.take(25));
+
+  if (!latestUsers.any((user) => user.userId == currentUser.userId)) {
+    latestUsers.insert(0, currentUser);


it's picky, but you could use a .sort() here instead to just move the current user to the front without the if

That only works if the user's in the list to begin with though, right?

ereio · 2022-04-20T14:05:12Z

lib/views/home/search/search-users-screen.dart

+            final screenshotController = ScreenshotController();
+            final avatar = MemoryFileSystem().file('avatar.png');
+
+            await screenshotController


Ignore the previous message, I just realized the Icon is an asset. You should be able to convert this to a bytestream without taking a screenshot. I can push something in a branch to help with this

Thank you. It has been driving me nuts how to get it out of its SVG

dnisbetjones · 2022-04-20T14:34:03Z

I think this looks excellent Ed! Well done!

EdGeraghty · 2022-04-20T14:40:16Z

Great work @EdGeraghty !

I'd like to make sure a few things are handled properly before merging. Have you tested what happens when a user searches themselves again after they've created a Note To Self? Does it automatically navigate them there like existing user DMs?

Thanks :)

I have 100% tested this in the past, but the code has gone through so many iterations that having just tested it now it seems to sit and hang rather than redirect... Is #671 related? 🤔

UnixPhonez · 2022-06-28T00:40:31Z

I'd like to add, "Note to Self" should be made by default. If an user attempts to send an message to themselves

EdGeraghty requested a review from ereio February 15, 2022 18:36

EdGeraghty added approved Current description and details of feature have been approved for dev by core team feature New feature or request UI/UX View only feature wip Not ready to merge labels Feb 15, 2022

EdGeraghty mentioned this pull request Feb 15, 2022

"Note To Self" #560

Open

EdGeraghty commented Feb 15, 2022

View reviewed changes

ereio changed the title ~~Feature/note to self~~ [feature] Note To Self Feb 22, 2022

EdGeraghty force-pushed the feature/note-to-self branch 2 times, most recently from 589902d to d604583 Compare February 22, 2022 10:26

EdGeraghty removed the approved Current description and details of feature have been approved for dev by core team label Mar 1, 2022

EdGeraghty force-pushed the feature/note-to-self branch from d604583 to e599ae0 Compare March 30, 2022 18:27

Ed Geraghty added 9 commits April 17, 2022 15:59

i18n: Note to Self string

8c65731

feature: Allow for creating Avatars from Icons

30542a3

chore: let the invite & search users screens know the current User

db0369b

feature: Add our User to the top of the list if it's not in the last 25

296c8fa

feature: when displaying our User, use i18n Note to Self & use note Icon

f58936b

chore: note to self room topic

b3628eb

refactor: Don't invite our own user to rooms we're creating

8b21bb2

feature: if it's a note to self, set the room name and topic

8accf96

refactor: we already know currentUser, so use it

50fae37

Ed Geraghty added 3 commits April 17, 2022 15:59

fix: if it's a "Note to Self", make sure we don't initialise it twice

4c21963

refactor: We can remove safely most of that clutter

06003b9

refactor: fix relative import & sort alphabetically

21bd3e7

EdGeraghty force-pushed the feature/note-to-self branch from e599ae0 to 21bd3e7 Compare April 19, 2022 06:59

Ed Geraghty added 5 commits April 19, 2022 08:17

chore: run linter

692a013

fix: funky braces

8c6f827

chore: remove unused variable

0008b93

chore: run linter

5e20396

feature: create the Avatar, "screenshot" to a RAM file, use that

5c50218

Sadly, this throws an error...

EdGeraghty commented Apr 20, 2022

View reviewed changes

lib/views/home/search/search-users-screen.dart Outdated Show resolved Hide resolved

EdGeraghty added the help wanted Extra attention is needed label Apr 20, 2022

Ed Geraghty added 2 commits April 20, 2022 14:03

fix: add StoreProvider outside our Avatar Widget

c99e8fd

fix: teeny tiny icon

588c2f5

EdGeraghty added ready for review ready for review or merging and removed help wanted Extra attention is needed wip Not ready to merge labels Apr 20, 2022

EdGeraghty marked this pull request as ready for review April 20, 2022 13:06

EdGeraghty requested review from 0x1a8510f2 and dnisbetjones April 20, 2022 13:06

EdGeraghty self-assigned this Apr 20, 2022

ereio reviewed Apr 20, 2022

View reviewed changes

Merge branch 'dev' into feature/note-to-self

2266195

EdGeraghty linked an issue Apr 22, 2022 that may be closed by this pull request

"Note To Self" #560

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Note To Self #569

[feature] Note To Self #569

EdGeraghty commented Feb 15, 2022 •

edited

Loading

EdGeraghty left a comment •

edited

Loading

ereio commented Feb 16, 2022

EdGeraghty commented Feb 16, 2022

EdGeraghty commented Feb 18, 2022

ereio commented Feb 21, 2022

EdGeraghty commented Feb 21, 2022

ereio commented Feb 22, 2022

ereio commented Mar 18, 2022

EdGeraghty commented Mar 19, 2022

EdGeraghty commented Mar 30, 2022

EdGeraghty commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022 •

edited

Loading

ereio left a comment

ereio Apr 20, 2022

ereio Apr 20, 2022

EdGeraghty Apr 20, 2022

ereio Apr 20, 2022 •

edited

Loading

EdGeraghty Apr 20, 2022

dnisbetjones commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022 •

edited

Loading

UnixPhonez commented Jun 28, 2022

[feature] Note To Self #569

Are you sure you want to change the base?

[feature] Note To Self #569

Conversation

EdGeraghty commented Feb 15, 2022 • edited Loading

Types

Changes

🔮 Features

🐛 Fixes

🔒 Security

🛠 Performance

📐 Refactoring

Media (if applicable)

QA

Final Checklist

EdGeraghty left a comment • edited Loading

Choose a reason for hiding this comment

ereio commented Feb 16, 2022

EdGeraghty commented Feb 16, 2022

EdGeraghty commented Feb 18, 2022

ereio commented Feb 21, 2022

EdGeraghty commented Feb 21, 2022

ereio commented Feb 22, 2022

ereio commented Mar 18, 2022

EdGeraghty commented Mar 19, 2022

EdGeraghty commented Mar 30, 2022

EdGeraghty commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022 • edited Loading

ereio left a comment

Choose a reason for hiding this comment

ereio Apr 20, 2022

Choose a reason for hiding this comment

ereio Apr 20, 2022

Choose a reason for hiding this comment

EdGeraghty Apr 20, 2022

Choose a reason for hiding this comment

ereio Apr 20, 2022 • edited Loading

Choose a reason for hiding this comment

EdGeraghty Apr 20, 2022

Choose a reason for hiding this comment

dnisbetjones commented Apr 20, 2022

EdGeraghty commented Apr 20, 2022 • edited Loading

UnixPhonez commented Jun 28, 2022

EdGeraghty commented Feb 15, 2022 •

edited

Loading

EdGeraghty left a comment •

edited

Loading

EdGeraghty commented Apr 20, 2022 •

edited

Loading

ereio Apr 20, 2022 •

edited

Loading

EdGeraghty commented Apr 20, 2022 •

edited

Loading