Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry-scanner): add gar, gcr and nexus support #1354

Merged
merged 32 commits into from
Oct 19, 2023
Merged

Conversation

maratsal
Copy link
Contributor

@maratsal maratsal commented Sep 12, 2023

What this PR does / why we need it:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Sep 12, 2023
@github-actions github-actions bot removed the no-tests Chart templates modified without test changes label Sep 13, 2023
@jprieto92 jprieto92 changed the title add gar support initial commit feat(registry-scanner): add gar, gcr and nexus support Sep 21, 2023
@github-actions github-actions bot dismissed their stale review September 21, 2023 08:13

All good!

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Sep 21, 2023
@jprieto92 jprieto92 marked this pull request as ready for review September 26, 2023 08:53
@jprieto92 jprieto92 requested review from a team as code owners September 26, 2023 08:53
@balinaveen
Copy link
Contributor

@sysdiglabs/vm-integrations can you please take a look at this PR and provide feedback? @airadier probably need your final thumbs up too.

@jprieto92 jprieto92 self-requested a review October 17, 2023 10:47
@airadier airadier enabled auto-merge (squash) October 19, 2023 07:46
@jprieto92 jprieto92 requested a review from airadier October 19, 2023 07:52
@airadier airadier merged commit e948b71 into master Oct 19, 2023
5 checks passed
@airadier airadier deleted the add-gar-support branch October 19, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants