Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(registry-scanner): specify the namespace to use during installation #1388

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Oct 2, 2023

What this PR does / why we need it:

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

@mavimo mavimo self-assigned this Oct 2, 2023
@mavimo mavimo requested review from a team as code owners October 2, 2023 16:15
@airadier
Copy link
Collaborator

@mavimo @AlbertoBarba , hopefully the tests should pass now after merging master. We disabled 2 tests for JFrog Artifactory SaaS because the test instance has been destroyed and they were failing.

Copy link
Contributor

@AlbertoBarba AlbertoBarba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if u only modify the README you currently need to bump the chart version.

cc @aroberts87 @mavimo

@airadier
Copy link
Collaborator

Even if u only modify the README you currently need to bump the chart version.

cc @aroberts87 @mavimo

That's right, now a version bump is required because of the latest changes happening in master, but at least the tests should be passing.

@mavimo mavimo force-pushed the specify-registry-scanner-namespace-in-doc branch from faa5940 to 1342493 Compare October 24, 2023 12:55
@mavimo mavimo enabled auto-merge (squash) October 24, 2023 12:56
@mavimo mavimo merged commit 87ba25b into master Oct 24, 2023
5 checks passed
@mavimo mavimo deleted the specify-registry-scanner-namespace-in-doc branch October 24, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants