Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agent): mount agent http-proxy credentials as secret #1517

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

francesco-furlan
Copy link
Contributor

@francesco-furlan francesco-furlan commented Dec 5, 2023

What this PR does / why we need it:

Mount agent http-proxy credentials as a secret in both agent DaemonSet and Deployment except when gke autopilot is enabled.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Check Contribution guidelines in README.md for more insight.

@francesco-furlan francesco-furlan requested a review from a team as a code owner December 5, 2023 13:57
@francesco-furlan francesco-furlan self-assigned this Dec 5, 2023
@francesco-furlan francesco-furlan force-pushed the SSPROD-25059-move-http-proxy-env-to-file branch from 8098d41 to 42d3af1 Compare December 5, 2023 16:48
@francesco-furlan francesco-furlan requested a review from a team December 5, 2023 16:52
charts/agent/Chart.yaml Outdated Show resolved Hide resolved
@francesco-furlan francesco-furlan force-pushed the SSPROD-25059-move-http-proxy-env-to-file branch from a4e0612 to 48349aa Compare December 5, 2023 20:26
@francesco-furlan francesco-furlan merged commit d17d3f8 into master Dec 6, 2023
5 checks passed
@francesco-furlan francesco-furlan deleted the SSPROD-25059-move-http-proxy-env-to-file branch December 6, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants