Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-analyzer): namespace variable for runtime-scanner and eve-connector #1518

Conversation

a1ex-var1amov
Copy link
Contributor

namespace variable for runtime-scanner and eve-connector added

namespace: {{ include "nodeAnalyzer.namespace" . }}

To Runtime-scanner and Eve-Connector templates to allow enforcing of the namespace name for all Node Analyzer components via helm values if needed. A patch for the following commit: e54e190#diff-470c10fc6cbb30417f83ca7121733fba9c8a2832a8b6825932cd5ac6247f3a62R7

What this PR does / why we need it:

  • an option to define a namespace for node-analyzer by default

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Check GithubAction checks (like lint) to avoid merge-check stoppers

Check Contribution guidelines in README.md for more insight.

@a1ex-var1amov a1ex-var1amov requested a review from a team as a code owner December 5, 2023 17:48
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hi @a1ex-var1amov. Thanks for your PR.

After inspecting your changes someone with write access to this repo needs
to approve and run the workflow with the following slash_command.

NOTE: the workflow triggered this way will only report the final status to this PR,
in order to check the logs please go to the Actions tab and look for approve-test-run-command.

  • /approve-test-run sha=<short commit sha to test>: Run helm chart linting and testing workflow

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/master/README.md#pull-requests

@github-actions github-actions bot added the no-tests Chart templates modified without test changes label Dec 5, 2023
@a1ex-var1amov a1ex-var1amov changed the title feat(node-analyzer) namespace variable for runtime-scanner and eve-connector feat(node-analyzer): namespace variable for runtime-scanner and eve-connector Dec 5, 2023
@github-actions github-actions bot dismissed their stale review December 5, 2023 18:13

All good!

@mavimo mavimo force-pushed the add-namespaces-eve-conn-runtime-scanner branch from bc1dc6c to 8cf8dc9 Compare December 11, 2023 09:18
@AlbertoBarba AlbertoBarba merged commit 809552f into sysdiglabs:master Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-tests Chart templates modified without test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants