feat(agent): [SMAGENT-8138][SMAGENT-8501] add full securityContext to agent charts #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the agent charts so to include a full securityContext. Beware of kubernetes/kubernetes#125012 affecting Windows kubelet. Also add relevant unit tests.
This reverts commit 47a953c.
This reverts commit 8c5d646.
francesco-furlan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the agent charts so to include a full securityContext. Beware of kubernetes/kubernetes#125012 affecting Windows kubelet.
Compared to #2017, just removed the "add: -ALL" part which was breaking some systems like ROKS and probably also Azure, which seemed unnecessary (probably redundant given we have
privileged: true).What this PR does / why we need it:
Checklist
feat(agent,node-analyzer,sysdig-deploy):)