-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the fontawesome API keys and modules #30
Conversation
…l but 1 case) and a different but similar icon (in that final case)
…g mock-shepherd (it seems to work fine)
Please could someone review this pull request, I've (to the best of my ability) only used the free icons from the same iconset as before (which will mean that all our icons are filled in but won't change stuff much), however a switch did have to be made (I replaced the arrow that opens or closes the files pane with a chevron, as the arrow is pro only). I've tested using https://github.com/systemetric/mock-shepherd, so I believe that everything works as before (excepting the minor visual changes), however it'd still be good to get someone else to look over this before merging. |
I'll have a look at this tonight or tomorrow, thank you for the work :) |
Thank you for this. This has been along time needed and I am glad someone has finally managed to do it :) I am unable to test this PR. As of b246ade shepherd does not serve sheep? Maybe I am doing something dumb? I've just run:
No logs are printed to the console. Checking out master works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure that sheep gets served.
I'm no longer able to review this PR, please find another reviewer. |
Review out of date with HEAD & reviewer no longer available
hmm... looks like you've pushed with the full website image files rather than the LFS pointers? |
Ahh, my bad in that case; best course of action would probably be to revert back to before I pushed files that should be on LFS & make the commit without the incorrect files |
revert or reset? I'm looking at them now but I'm not sure lol |
d1874e3
to
dd87e49
Compare
(it looks like I messed up my rebase and it didn't fix it, I'm going to revert that) |
dd87e49
to
d1874e3
Compare
d1874e3
to
50a607d
Compare
…advertently deleted. My issue before was using updatebuild rather than build which seems to commit images to the repo too
@casheww I've fixed that now (I was using 'npm run updatebuild' rather than 'npm run build' which seemed to get all the images and add them.) Thanks for pointing that out & being patient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to work on the brain I have! Awesome job :)
I'm still a bit cautious about merging into shepherd:master though, so I will just tag in @WillMunns , and hopefully we can talk about this on Saturday? I'm sure he'll want to test it at some point |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty <3.
I think that this should be merged now that RoboCon 2022 is over and we are now in the pre-release-candidate window for 2023.
Now that RoboCon has past I think that we should merge this so that #29 can become unblocked. There is no risk as the next release candidate for RoboCon-2023 will be after the summer. |
Now that this PR is done, I presume we're good to make this repo public? @shardros can you confirm that you've invalidated the API keys as well as merging this PR, and if so I'll publicize the repo |
Actually, taking a look back at #21, it's @mrbbot who has the token. Please may you invalidate the token and tell me when you're done? |
This PR resolves #21