Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak(web/standalone/deployer.ejs) update keymaster link to new portal #1022

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Gravxd
Copy link
Contributor

@Gravxd Gravxd commented Jan 5, 2025

No description provided.

@Gravxd Gravxd requested a review from tabarra as a code owner January 5, 2025 05:14
@Misha0717
Copy link

Dupe of #1016

@tabarra tabarra changed the base branch from master to develop January 10, 2025 07:34
@tabarra
Copy link
Owner

tabarra commented Jan 10, 2025

Yes, dupe, but the other is "stale" (well, one week).
If you implement the change requested I merge this one instead.

I think it's a good opportunity to include a link to the new docs page:
https://support.cfx.re/hc/en-us/articles/16539369935900-How-to-create-a-registration-key

On a quick note, small stuff like this I usually prefer just doing myself, and actually had already done the change but didn't commit.
But I'm happy to merge community PRs, and community members are usually happy to help so I'm fine with accepting PRs instead.

@Gravxd
Copy link
Contributor Author

Gravxd commented Jan 10, 2025

Didn't see another PR, mb on the dupe - link is updated as requested though

@tabarra
Copy link
Owner

tabarra commented Jan 14, 2025

The link was correct 😝
What I meant was also adding a link to the docs, like a For more information, read the [documentation](https://...), or even just (docs) with a link.

@Gravxd
Copy link
Contributor Author

Gravxd commented Jan 14, 2025

Medal_zf8djO3R4U
Something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants