This repository has been archived by the owner on May 3, 2024. It is now read-only.
forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 125
Support eip-1559 and Evm-circuit in aggregation #136
Merged
smtmfft
merged 61 commits into
taikoxyz:feat/for-a6-release
from
johntaiko:feat/evm_circuit_1559
Sep 21, 2023
Merged
Support eip-1559 and Evm-circuit in aggregation #136
smtmfft
merged 61 commits into
taikoxyz:feat/for-a6-release
from
johntaiko:feat/evm_circuit_1559
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
github-actions
bot
added
crate-bus-mapping
crate-circuit-benchmarks
crate-eth-types
labels
Aug 11, 2023
@Brechtpd Now, we use |
johntaiko
force-pushed
the
feat/evm_circuit_1559
branch
2 times, most recently
from
August 20, 2023 13:45
e3451a5
to
2196cf8
Compare
…es (privacy-scaling-explorations#1424) 1. Add Shanghai related fields to chain config in geth-utils. 2. EIP-3651 (Warm COINBASE): add a new access-list write for coinbase to Begin TX. 3. Part of EIP-3860 (Limit and meter initcode): only add gas cost of init code to Begin TX (missing gas cost changes in Create and OOG Create). Issue privacy-scaling-explorations#1362 Local related PRs: scroll-tech#497 scroll-tech#500 scroll-tech#507 Reference previous PR: privacy-scaling-explorations#1361 - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) Unit test cases of CI could pass with Shanghai geth traces. --------- Co-authored-by: Zhang Zhuo <[email protected]>
johntaiko
force-pushed
the
feat/evm_circuit_1559
branch
from
August 20, 2023 13:50
2196cf8
to
46c5125
Compare
Using real data with one anchor transaction is passed in zkevm-chain. taikoxyz/zkevm-chain#6 |
johntaiko
commented
Aug 21, 2023
Looked through the code again, all looks good to me! |
johntaiko
force-pushed
the
feat/evm_circuit_1559
branch
from
August 28, 2023 13:44
b050ba5
to
c1af675
Compare
johntaiko
force-pushed
the
feat/evm_circuit_1559
branch
from
September 21, 2023 05:54
0dee923
to
c1af675
Compare
… into feat/evm_circuit_1559
yueawang
approved these changes
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous: smtmfft#18
Tasks:
feat: mock supports eip-1559 and anchor johntaiko/zkevm-circuits#5feat: support eip-1559 signature johntaiko/zkevm-circuits#6mixHash
insteadblock.difficuty
https://eips.ethereum.org/EIPS/eip-4399