add "server/workspace up/down" commands for consistency #1391
Conversation
|
good idea to keep them consistent. fine by me. Should we deprecate the other two? |
|
not sure if it's worth the trouble. don't know what the general stance on deprecation is in the community repo. i see the deprecate_notify function but no uses of it. should we merge this already and create an issue for the deprecation decision of the two commands that are "backwards"? |
|
you want to search for user.deprecate_command use instead. I believe the stance is to always do it, see 54ce69d for a recent one. I'm fine with merging this if you prefer to do a separate PR for deprecation. if you don't want to do it, let me know and I'll throw one together. I agree it's a bit of a hassle, but we don't have any visibility into how many people even use community afaik, and the agreement was that we slowly deprecate stuff, so still seems worth to be on the safe side. |
timo
force-pushed
the
messaging_workspace_updown_commands
branch
from
3d8beca to
3a85f5f
Compare
| @@ -3,6 +3,8 @@ tag: user.messaging | |||
| # Navigation | |||
| previous (workspace | server): user.messaging_workspace_previous() | |||
There was a problem hiding this comment.
Please deprecate these old commands using user.deprecate_command
| @@ -3,6 +3,8 @@ tag: user.messaging | |||
| # Navigation | |||
| previous (workspace | server): user.messaging_workspace_previous() | |||
| next (workspace | server): user.messaging_workspace_next() | |||
| (workspace | server) up: user.messaging_workspace_previous() | |||
There was a problem hiding this comment.
Please also support next/previous in addition to up/down.
this mirrors "channel up/down" from the same file, and mirrors the more common "noun verb" order in commands