refactor: move command_client folder into core #1448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly just a nit, but every time I go to find
command_client/
in community I go to the wrong place, because I don't associate it with vscode. Since there's other users of it now, like neovim-talon now, it probably makes sense for this to just become part ofcore/
. It could also be suited toplugin/
, but if we ever decided to move all of the app-specific stuff (only vscode and visual_studio atm) into the associatedapps/<foo>/
folders then this would beapps/
relying onplugin/
which we don't want.