Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symbols from create spoken forms & migrate to *.talon-list #1638

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Remove symbols from create spoken forms & migrate to *.talon-list #1638

wants to merge 24 commits into from
+116 −104

Conversation

knausj85
Copy link
Member

knausj85 and others added 10 commits December 14, 2024 15:14
@knausj85
Remove symbols from create spoken forms & migrate remaining keys list…
3028ae3 
…s to *.talon-list

#1561
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
057eb2d 
for more information, see https://pre-commit.ci
@knausj85
Update create_spoken_forms.py
6bce77c 
bugfix
@knausj85
Merge branch 'create-spoken-form-remote-symbols' of https://github.co…
f291cbf 
…m/talonhub/community into create-spoken-form-remote-symbols
@knausj85
Update test_create_spoken_forms.py
ee47ffb
@knausj85
Update create_spoken_forms.py
eadc481
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
47e2ddf 
for more information, see https://pre-commit.ci
@knausj85
Update create_spoken_forms.py
d01743f 
restore dotted form for now
@knausj85
preserve set functionality to remove duplicates, fix unit tests.
1e30068
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0762dfa 
for more information, see https://pre-commit.ci
@knausj85 knausj85 marked this pull request as ready for review December 14, 2024 23:22
@knausj85
Copy link
Member Author

This is ready for folks to test in order to decide whether we want to proceed with the change.

knausj85 and others added 3 commits December 14, 2024 21:27
@knausj85 knausj85 mentioned this pull request Jan 1, 2025
Open
@AndreasArvidsson AndreasArvidsson marked this pull request as draft January 11, 2025 17:30
@knausj85 knausj85 marked this pull request as ready for review January 19, 2025 18:00
@knausj85
Copy link
Member Author

After our discussion, I've settled on a compromise of keeping support for a handful of symbols. Unfortunately, this does mean folks have to define them in two places. However, I feel it is a step in the right direction.

This is ready for review.

nriley
nriley requested changes Jan 25, 2025
View reviewed changes
core/keys/symbol_key.talon-list Show resolved Hide resolved
core/keys/symbol_key.talon-list Outdated Show resolved Hide resolved
@knausj85 knausj85 requested a review from nriley January 25, 2025 15:41
nriley
nriley reviewed Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@nriley nriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I haven't run with it yet!

@nriley nriley self-requested a review January 25, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nriley nriley Awaiting requested review from nriley

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knausj85 @nriley