Skip to content

Commit

Permalink
cmake: Remove Boost.Python dependency
Browse files Browse the repository at this point in the history
Since some of the required functionality is not supported, it was
supersided by own python C API wrappers.
This is to avoid weird bugs due to GIL and Python's internal global
states and the Boost.Python library and custom functions interfering
with each other.
  • Loading branch information
taminob committed Mar 27, 2024
1 parent 3de88f8 commit 476e2c9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ option(PPPLUGIN_ENABLE_UNDEFINED_SANITIZE
option(PPPLUGIN_ENABLE_UNREACHABLE_SANITIZE
"Enable compilation with unreachable sanitize flags" OFF)

find_package(Boost 1.61.0 REQUIRED COMPONENTS headers filesystem python)
find_package(Boost 1.61.0 REQUIRED COMPONENTS headers filesystem)
find_package(Python 3.0 REQUIRED COMPONENTS Development)
find_package(Lua 5.2 REQUIRED)

Expand Down
1 change: 0 additions & 1 deletion src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ add_library(${LIBRARY_TARGET} ${LIBRARY_SOURCES})
target_link_libraries(
${LIBRARY_TARGET}
PUBLIC Boost::filesystem
PUBLIC Boost::python
PUBLIC Python::Python
PRIVATE ${LUA_LIBRARIES})
if(${PPPLUGIN_ENABLE_CPP17_COMPATIBILITY})
Expand Down

0 comments on commit 476e2c9

Please sign in to comment.