Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move Soldeer dependencies #38

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix: move Soldeer dependencies #38

merged 1 commit into from
Nov 20, 2024

Conversation

Serial-ATA
Copy link
Contributor

Overview

  • As far as I can tell, Soldeer will always put the dependencies in the root. I moved foundry.toml into contracts/ to fix that.
  • I had to manually add append /src to the tnt-core remapping
  • Remove submodules from Dependabot
  • Fixed import in HelloBlueprint.sol (Soldeer keeps versions in the path)

@Serial-ATA Serial-ATA requested a review from shekohex November 19, 2024 20:02
@Serial-ATA Serial-ATA marked this pull request as draft November 19, 2024 20:10
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We need to keep the foundry.toml in the root path, otherwise you cannot run foundry build/test from the root, and you have to path --root ./contracts everywhere to get it to work.
  2. The remappings.txt should be kept outside of the config; most of the Solidity LSP reads this file, so we need to keep it separate.
  3. No need to use versioning in the imports, it's not the idiom in Solidity, instead we put tnt-core/=dependencies/tnt-core-0.1.0/src/ or something like that in the remapping.txt
    Soldeer does not (by default) update the remapping there is a flag for that afaik, and we don't need it for now.

@Serial-ATA Serial-ATA force-pushed the serial/fix-soldeer branch 2 times, most recently from edbab17 to c1ec60c Compare November 20, 2024 16:14
@Serial-ATA Serial-ATA marked this pull request as ready for review November 20, 2024 16:32
@Serial-ATA Serial-ATA requested a review from shekohex November 20, 2024 16:33
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small change, otherwise looks good!

remappings.txt Outdated Show resolved Hide resolved
contracts/src/HelloBlueprint.sol Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@drewstone drewstone merged commit 46b1785 into main Nov 20, 2024
1 check passed
@Serial-ATA Serial-ATA deleted the serial/fix-soldeer branch November 20, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants