Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Restake evm asset E2E Tests #865

Merged
merged 13 commits into from
Jan 7, 2025
Merged

feat: Restake evm asset E2E Tests #865

merged 13 commits into from
Jan 7, 2025

Conversation

shekohex
Copy link
Contributor

@shekohex shekohex commented Jan 1, 2025

Summary of changes
Changes introduced in this pull request:

This pull request introduces several significant changes to the project, including updates to the CI workflow, dependency additions, and enhancements to the end-to-end testing framework. The most important changes are summarized below:

CI Workflow Enhancements:

  • Added a new e2e job to the GitHub Actions workflow to run end-to-end tests. This includes setting up the environment, installing necessary tools, and running the test suite.

Codebase Enhancements:

  • Added conditional compilation attributes to tests in node/src/distributions/mainnet.rs to exclude them when the testnet feature is enabled. [1] [2] [3]
  • Introduced a new module manual_seal in node/src/lib.rs and updated the service module to conditionally include it based on the manual-seal feature.

End-to-End Testing Framework:

  • Added a comprehensive end-to-end testing framework in node/tests/common/mod.rs that includes a CliWrapper, test account management, and utility functions for running tests.
  • Added evm_restaking test for covering restaking on MAD pallet through the precompile.
  • This covers the whole End to End flow of restaking an ERC20 and custom assets.

What is next?

Building on top of this PR, the next would be the following:

  1. Create End to End test to cover rewards
  2. Another End to End test to cover restaking using another smart contract.
  3. Add more edge cases, if you have ideas in mind, please write them down in this checklist [CHECKLIST] Integration tests for restaking flow #861

Reference issue to close (if applicable)

Covers items from this checklist #861

@shekohex shekohex marked this pull request as ready for review January 6, 2025 20:53
@drewstone drewstone merged commit de96ce5 into main Jan 7, 2025
4 checks passed
@drewstone drewstone deleted the shady/restaking-e2e-01 branch January 7, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants