api: implement VshardRouterCallResp.GetTransparent method (resolve #22) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaymeKaydex
reviewed
Jan 10, 2025
| // If you have some custom decoder for some lua handler's response, you can reuse your decoder using this method. | ||
| // P.S. the maximum length of the response array is cut to 3 elements due to lua vshard storage implementation | ||
| // see https://github.com/tarantool/vshard/blob/dfa2cc8a2aff221d5f421298851a9a229b2e0434/vshard/storage/init.lua#L3130. | ||
| func (r VshardRouterCallResp) GetTransparent(result interface{}) error { |
There was a problem hiding this comment.
i think it better to use upcast in GetTyped func instead new decode function
and always use buffer instead raw messages and repack it
KaymeKaydex
reviewed
Jan 10, 2025
| @@ -111,3 +111,54 @@ func TestRouterCallProto(t *testing.T) { | |||
| _, _, err = router.RouterCallImpl(ctx, bucketID, callOpts, "echo", args) | |||
| require.Nil(t, err, "RouterCallImpl echo finished with no err even on dirty bucket map") | |||
| } | |||
|
|
|||
| func TestRouterCallProto(t *testing.T) { | |||
There was a problem hiding this comment.
we also dont use tests/tnt folder anymore, use tarantool_test.go instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues: