PacketSource should contain .to_hdf() method
#2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atharva-2001
commented
Apr 15, 2024
Comment on lines
80
to
88
| # def test_blackbody_regressions( | ||
| # self, blackbodysimplesource | ||
| # ): | ||
| # expected = pd.read_hdf( | ||
| # self.regression_data.fpath, key="/black_body_simple_source/scalars" | ||
| # ) | ||
| # np.testing.assert_allclose( | ||
| # expected.base_seed, blackbodysimplesource.base_seed | ||
| # ) |
There was a problem hiding this comment.
@andrewfullard Do we want to keep this test? Or do I need to change some other test module to test this change?
There was a problem hiding this comment.
If we could test this for the entire source output, that would be very useful.
There was a problem hiding this comment.
the packet source at this moment only has the base seed, other attributes are none I'm afraid
atharva-2001
force-pushed
the
packet_source_hdf
branch
from
61e156e to
c972395
Compare
6 tasks
andrewfullard
previously approved these changes
Apr 17, 2024
andrewfullard
approved these changes
Apr 18, 2024
|
*beep* *bop* Hi, human. The Click here to see your results. |
andrewfullard
requested changes
Apr 24, 2024
atharva-2001
force-pushed
the
packet_source_hdf
branch
from
9983c82 to
d0c2be6
Compare
andrewfullard
previously approved these changes
May 6, 2024
atharva-2001
force-pushed
the
packet_source_hdf
branch
from
d0c2be6 to
0b8fb8b
Compare
andrewfullard
approved these changes
May 24, 2024
jvshields
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🚀
featureResolves #2438
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel